Skip to content
This repository has been archived by the owner on May 29, 2018. It is now read-only.

Usage of non-standard naming convention for enumerations #83

Open
slimsag opened this issue Nov 2, 2015 · 1 comment
Open

Usage of non-standard naming convention for enumerations #83

slimsag opened this issue Nov 2, 2015 · 1 comment

Comments

@slimsag
Copy link
Member

slimsag commented Nov 2, 2015

As discovered in #75 (comment) we use a non-standard naming convention for enumerations (per the official protobuf style guide).

We should switch from the Go style of CamelCase to the official protobuf style of UPPER_CASE instead, and ensure that protobuf-gen-gogo or whatever generates the Go source is emitting these with nice Go names as we desire.

This is important for consistency esp. with regard to supporting other languages.

@dmitshur
Copy link
Contributor

dmitshur commented Nov 2, 2015

I agree. Our Go code should follow the Go style, and protobuf code should use protobuf style.

That's the right thing to do, even though it means following/knowing 2 styles for us.

But it's going to be friendlier to people using other languages or more familiar with protobufs.

@dmitshur dmitshur mentioned this issue Nov 3, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants