Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jaeger Tracing in Docker Compose #489

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Aug 3, 2021

Jaeger is not working on Docker Compose currently due to missing env var stated in https://github.com/sourcegraph/sourcegraph/issues/21677#issuecomment-889433798
This PR adds the missing env var SAMPLING_STRATEGIES_FILE=/etc/jaeger/sampling_strategies.json so that jaeger can work on Docker Compose instances properly.

Checklist

@bobheadxi
Copy link
Member

Seemed to pass after giving the CI a kick, seemed to be a network flake :)

@abeatrix abeatrix merged commit 2e4afd8 into master Aug 4, 2021
@abeatrix abeatrix deleted the bee/enable-tracing branch August 4, 2021 07:43
@abeatrix
Copy link
Contributor Author

abeatrix commented Aug 4, 2021

Thanks for checking @bobheadxi ! Will I need to update the changelog to reflect the changes as well?

@bobheadxi
Copy link
Member

I would recommend something like this:

Changed

  • docker-compose: the Jaeger container's SAMPLING_STRATEGIES_FILE now has a default value. If you are currently using a custom sampling strategies configuration, you may need to make sure your configuration is not overridden by the change when upgrading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants