Skip to content
This repository was archived by the owner on Oct 29, 2021. It is now read-only.

Commit f056451

Browse files
committed
improvements on comments, unnecessary code & codestyle
1 parent 2d762fe commit f056451

File tree

1 file changed

+7
-11
lines changed

1 file changed

+7
-11
lines changed

influxdb_store.go

+7-11
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ const (
2020
schemasFieldName string = "schemas" // Span's measurement field name for schemas field.
2121
schemasFieldSeparator string = "," // Span's measurement character separator for schemas field.
2222
spanMeasurementName string = "spans" // InfluxDB container name for trace spans.
23-
testDBName string = "appdash_test" // InfluxDB test DB name.
23+
testDBName string = "appdash_test" // InfluxDB test DB name (will be deleted entirely in test mode).
2424
)
2525

2626
type mode int
@@ -262,8 +262,8 @@ func (in *InfluxDBStore) createDBIfNotExists() error {
262262
if err != nil {
263263
return err
264264
}
265-
if response.Error() != nil {
266-
return response.Error()
265+
if err := response.Error(); err != nil {
266+
return err
267267
}
268268
return nil
269269
}
@@ -294,8 +294,8 @@ func (in *InfluxDBStore) executeOneQuery(command string) (*influxDBClient.Result
294294
if err != nil {
295295
return nil, err
296296
}
297-
if response.Error() != nil {
298-
return nil, response.Error()
297+
if err := response.Error(); err != nil {
298+
return nil, err
299299
}
300300

301301
// Expecting one result, since a single query is executed.
@@ -368,10 +368,6 @@ func (in *InfluxDBStore) init(server *influxDBServer.Server) error {
368368
return err
369369
}
370370
switch in.mode {
371-
case releaseMode:
372-
if err := in.setUpReleaseMode(); err != nil {
373-
return err
374-
}
375371
case testMode:
376372
if err := in.setUpTestMode(); err != nil {
377373
return err
@@ -402,8 +398,8 @@ func (in *InfluxDBStore) setUpTestMode() error {
402398
if err != nil {
403399
return err
404400
}
405-
if response.Error() != nil {
406-
return response.Error()
401+
if err := response.Error(); err != nil {
402+
return err
407403
}
408404
return nil
409405
}

0 commit comments

Comments
 (0)