Skip to content
This repository has been archived by the owner on May 24, 2022. It is now read-only.

Add contact pages #27

Merged
merged 21 commits into from
Mar 10, 2022
Merged

Add contact pages #27

merged 21 commits into from
Mar 10, 2022

Conversation

katjuell
Copy link
Contributor

@katjuell katjuell commented Mar 8, 2022

Closes #25 and #24 by adding contact pages and converting the createHubSpot function (formerly defined under components into a hook.

NB: There's currently a redirect for request-trial, which we'll get to when we port over #10.

To Test

  • Check out the branch, and spot check pages under contact.
  • Make sure that forms load and that pages with ChiliPiper also load that script.
  • Check out mobile styles, make sure everything looks okay.
  • Check static builds.

src/pages/contact/index.tsx Outdated Show resolved Hide resolved
@katjuell katjuell requested a review from bretthayes March 8, 2022 18:46
@katjuell katjuell added the team/content-platform Content Platform Team related tickets. label Mar 8, 2022
@katjuell katjuell self-assigned this Mar 8, 2022
Copy link
Contributor

@bretthayes bretthayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few comments. Also, I noticed that all the forms are different between prod and local 🕵🏻‍♂️

src/components/Layout/index.tsx Outdated Show resolved Hide resolved
src/hooks/hubSpot.ts Show resolved Hide resolved
src/hooks/hubSpot.ts Outdated Show resolved Hide resolved
src/hooks/hubSpot.ts Show resolved Hide resolved
src/pages/contact/index.tsx Outdated Show resolved Hide resolved
src/pages/contact/index.tsx Outdated Show resolved Hide resolved
src/pages/contact/product-specialist.tsx Show resolved Hide resolved
src/pages/contact/request-batch-changes-demo.tsx Outdated Show resolved Hide resolved
src/pages/contact/index.tsx Outdated Show resolved Hide resolved
src/pages/contact/request-trial.tsx Outdated Show resolved Hide resolved
@katjuell
Copy link
Contributor Author

katjuell commented Mar 9, 2022

@bretthayes just a couple of questions back to you as I wrap this up — I think everything else is resolved! Unsure why those forms look different — I don't think it's on our end, is it, if we are using the correct ids and all that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team/content-platform Content Platform Team related tickets.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port over contact pages components
2 participants