fix(core): resolve Valid workflow issues #47
Conversation
resolve issues so that it can create valid workflow GH-42
|
==== Karma Test Coverage ==== |
| const valueTypeIsAnyValue = | ||
| node.node.state.get('valueType') === ValueTypes.AnyValue; | ||
| isValid = columnExists && (valueExists || valueTypeIsAnyValue); | ||
| break; |
There was a problem hiding this comment.
Shouldn't this be part of the respective node classes?
There was a problem hiding this comment.
yes it should be , can u plz tell me the approach which i should follow sir, but sir we need to give this in emergency so
There was a problem hiding this comment.
Approving for now assuming this would be fixed as part of a separate issue
There was a problem hiding this comment.
sure sir ,I will create the seprate issue of this .
|
==== Karma Test Coverage ==== |
|
@Deepika516 create a new issue and link it here |
resolve issues so that it can create valid workflow
GH-42
Description
Do this Condition & When this happens condition is not optional so without this the workflow cannot be saved.workflow should be valid when saved .
Fixes #42
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: