-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Menu button clipping #8
Comments
By hiding the menu button on userChrome.css the padding seems to be fixed ... Ends up looking like this. Since the theme itself requires the menu bar to work correctly, it is safe to hide the menu button |
Good point @AlexyBot. If you're happy for me to I'd like to put that in the readme as a user preference. I'm not going to roll that into the main theme as I'd rather fix the source than hide the button, especially as I intend to eventually make the theme work with and without the menubar. But as a user preference it's good. |
Go ahead, you're the theme creator after all :p |
Good spot @TheiaDraizer. Helps to debug this a bit better. Looks like perhaps the list-item layout of the m enu button now overlap, providing it a bit of a gap to lean into. I'm going to test this a bit more as I needed to specify a different value else it would have a noticable gap, but otherwise looks like the right track. |
Adjustments have been made to make it account for Compact, Normal and Touch modes. There's probably a better way to do it, but for lack of discovering one - this one should make this theme reusable for people again. Thanks all for the assist on this. @AlexyBot FYI this will make a padded space on your adjustment. I've updated the instructions on the readme so you can keep it looking like you wanted.
|
There appears to be a clipping issue, with the menu button appearing to get cut off on the right-hand side. So far experienced in Xubuntu 22.04, and in the Gitpod instance.
The text was updated successfully, but these errors were encountered: