From 2c4e19c44b9101db28ca775e4eb2e1b222fca413 Mon Sep 17 00:00:00 2001 From: Xie Zhihao Date: Wed, 2 Nov 2022 09:53:41 +0000 Subject: [PATCH] network: ensure connect request will get submitted Signed-off-by: Xie Zhihao --- source/common/network/io_uring_socket_handle_impl.cc | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/source/common/network/io_uring_socket_handle_impl.cc b/source/common/network/io_uring_socket_handle_impl.cc index 904bd651fcefd..8c5151518b10f 100644 --- a/source/common/network/io_uring_socket_handle_impl.cc +++ b/source/common/network/io_uring_socket_handle_impl.cc @@ -228,10 +228,8 @@ Api::SysCallIntResult IoUringSocketHandleImpl::connect(Address::InstanceConstSha res = uring.prepareConnect(fd_, address, req); RELEASE_ASSERT(res == Io::IoUringResult::Ok, "unable to prepare connect"); } - if (isLeader()) { - // TODO(rojkov): handle `EBUSY` in case the completion queue is never reaped. - uring.submit(); - } + // Need to ensure the connect request submitted. + uring.submit(); return Api::SysCallIntResult{0, SOCKET_ERROR_IN_PROGRESS}; }