Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acq anom warnings don't use dither adjusted position to check for out-of-box case. #139

Open
jeanconn opened this issue Jul 6, 2017 · 1 comment

Comments

@jeanconn
Copy link
Contributor

jeanconn commented Jul 6, 2017

This code

https://github.com/sot/mica/blob/master/mica/stats/acq_stats.py#L465

Doesn't use the OBC attitude when determining the offset from the expected star position.

I think using 'dy' and 'dz' from the acq stats database would be more reliable.

As written, it is very close, but if we used 'dy', 'dz' we wouldn't see the "non-standard" warning for 18302 as slot 5 would be within 160 + 16 in Y (it is at -175 from expected position with dy, but -195 using the yang-yang_obs test).

@jeanconn
Copy link
Contributor Author

jeanconn commented Jul 6, 2017

Note that we still want dy and dz, not cdy/cdz. In this case the cdy/cdz have back-propagated one-shot corrections, and those aren't needed just to see if the star was really in the box that was commanded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant