Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace random with secrets #5

Open
AdamJCavanaugh opened this issue Jun 1, 2023 · 2 comments
Open

Replace random with secrets #5

AdamJCavanaugh opened this issue Jun 1, 2023 · 2 comments

Comments

@AdamJCavanaugh
Copy link
Contributor

passgen.py:168: DeprecationWarning: The random parameter to shuffle() has been deprecated since Python 3.9 and will be removed in a subsequent version.
@AdamJCavanaugh
Copy link
Contributor Author

We need password generation at work. I spent a while digging through various password generators on pip and like this one best. I'm happy to provide a PR outside work hours, if you're still maintaining this. If you're not maintaining (since it's not very active), I'd be open to helping as needed. If you're not maintaining, I'll just eventually fork a local copy with a fix at work.

@soslan
Copy link
Owner

soslan commented Jun 1, 2023

Hi! Thank you very much for your feedback. I totally missed the removal of random.shuffle().

I still intend to maintain this, but unfortunately have little free time. Not only this project is open for PR's, but new maintainers are also very welcome. I can add you as a maintainer, if you will. Otherwise I will try my best, and patch it by Sunday.

@AdamJCavanaugh AdamJCavanaugh mentioned this issue Jun 1, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace random with secrets AdamJCavanaugh/passgen
2 participants
@soslan @AdamJCavanaugh