-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fresh breath #502
Open
0x009922
wants to merge
77
commits into
next
Choose a base branch
from
fresh-breath
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fresh breath #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ctepan
approved these changes
Mar 9, 2023
0x009922
commented
Mar 9, 2023
There is yarn in docs. As far as I understand, it should be changed to pnpm commands |
(exclude unnecessary files from the build)
Discussion notes: we decided to not merge it into |
Signed-off-by: Nikita Zaporozhets <[email protected]>
Signed-off-by: Nikita Zaporozhets <[email protected]>
Signed-off-by: Nikita Zaporozhets <[email protected]>
Signed-off-by: Nikita Zaporozhets <[email protected]>
This was
linked to
issues
Mar 28, 2023
[DOPS: 2312] Create images with corepack
Signed-off-by: Nikita Zaporozhets <[email protected]>
[DOPS-2312]: Use corepack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
SAlert
component so far.rollup-plugin-dts
for.d.ts
bundlemodule
^x.y
in prod dependencies for better (?) deps resolution experience of library usersThis PR leaves a lot of TODOs and FIXMEs, and I think those should be fixed separately. Also I think it makes sense to release new versions with a pre-release tag, because there might be unexpected regressions.
To-Do
Issues to be resolved after the merge:
Fixes #423