[crm] Errors in syslog due to contradiction between SAI attribute appropriate API in handling section

[ayurkiv-nvda]

Description

On latest master image you can find following CRM related error logs:

Dec  7 16:06:33.999613 r-lionfish-16 ERR swss#orchagent: :- objectTypeGetAvailability: attr SAI_IPMC_ENTRY_ATTR_PACKET_ACTION is not resource type
Dec  7 16:06:33.999613 r-lionfish-16 ERR swss#orchagent: :- getResAvailableCounters: Failed to get availability for object_type 54 , rv:-5

Root cause: contradiction between attribute in map and corresponding API under "switch - case"

https://github.com/Azure/sonic-swss/blob/master/orchagent/crmorch.cpp#L72

 { CrmResourceType::CRM_SRV6_MY_SID_ENTRY, SAI_OBJECT_TYPE_MY_SID_ENTRY },
 { CrmResourceType::CRM_SRV6_NEXTHOP, SAI_SWITCH_ATTR_AVAILABLE_IPV6_NEXTHOP_ENTRY },  <--- possibly wrong  

For SAI_SWITCH_ATTR_AVAILABLE_IPV6_NEXTHOP_ENTRY attribute should be other API, not the sai_object_type_get_availability()

sai_object_type_get_availability() expect SAI_OBJECT_TYPE_* attribute

Steps to reproduce the issue:

1. install latest master image
2. crm config polling interval 1
3. check logs

Describe the results you received:

Error logs in syslog

Describe the results you expected:

no errors

Output of show version:

admin@r-lionfish-16:~$ show vers

SONiC Software Version: SONiC.master.232-a8cf99087_Internal
Distribution: Debian 11.1
Kernel: 5.10.0-8-2-amd64
Build commit: a8cf99087
Build date: Mon Dec  6 10:32:21 UTC 2021
Built by: sw-r2d2-bot@r-build-sonic-ci02-241

Platform: x86_64-mlnx_msn3420-r0
HwSKU: ACS-MSN3420
ASIC: mellanox
ASIC Count: 1
Serial Number: MT2019X13878
Model Number: MSN3420-CB2FO
Hardware Revision: A1
Uptime: 16:15:17 up 11 min,  1 user,  load average: 0.35, 0.81, 0.65

Docker images:
REPOSITORY                                         TAG                             IMAGE ID       SIZE
docker-syncd-mlnx                                  latest                          5440683d2922   1.01GB
docker-syncd-mlnx                                  master.232-a8cf99087_Internal   5440683d2922   1.01GB
docker-platform-monitor                            latest                          654f04d81369   806MB
docker-platform-monitor                            master.232-a8cf99087_Internal   654f04d81369   806MB
docker-dhcp-relay                                  latest                          4f1c0f2638f6   436MB
docker-teamd                                       latest                          ce80b6213fcd   435MB
docker-teamd                                       master.232-a8cf99087_Internal   ce80b6213fcd   435MB
docker-sonic-telemetry                             latest                          02b09c852d76   511MB
docker-sonic-telemetry                             master.232-a8cf99087_Internal   02b09c852d76   511MB
docker-sonic-mgmt-framework                        latest                          0e42b7eeeef1   578MB
docker-sonic-mgmt-framework                        master.232-a8cf99087_Internal   0e42b7eeeef1   578MB
docker-snmp                                        latest                          f4a230bc43e2   465MB
docker-snmp                                        master.232-a8cf99087_Internal   f4a230bc43e2   465MB
docker-sflow                                       latest                          80697f03734a   436MB
docker-sflow                                       master.232-a8cf99087_Internal   80697f03734a   436MB
docker-router-advertiser                           latest                          4506108b1678   423MB
docker-router-advertiser                           master.232-a8cf99087_Internal   4506108b1678   423MB
docker-orchagent                                   latest                          eae845865ad7   454MB
docker-orchagent                                   master.232-a8cf99087_Internal   eae845865ad7   454MB
docker-nat                                         latest                          42f240308230   438MB
docker-nat                                         master.232-a8cf99087_Internal   42f240308230   438MB
docker-mux                                         latest                          18f7a6e9771d   475MB
docker-mux                                         master.232-a8cf99087_Internal   18f7a6e9771d   475MB
docker-macsec                                      latest                          232e532c3a32   439MB
docker-macsec                                      master.232-a8cf99087_Internal   232e532c3a32   439MB
docker-lldp                                        latest                          63e36e42da6b   463MB
docker-lldp                                        master.232-a8cf99087_Internal   63e36e42da6b   463MB
docker-fpm-frr                                     latest                          d0e34295feca   454MB
docker-fpm-frr                                     master.232-a8cf99087_Internal   d0e34295feca   454MB
docker-database                                    latest                          3711d6be4b1e   423MB
docker-database                                    master.232-a8cf99087_Internal   3711d6be4b1e   423MB
urm.nvidia.com/sw-nbu-sws-sonic-docker/sonic-wjh   1.0.0-master-internal-13        0f5b542c9bcf   470MB

Output of show techsupport:

(paste your output here or download and attach the file here )

Additional information you deem important (e.g. issue happens only occasionally):

These 2 messages are already fixed by this PR sonic-net/sonic-swss#2057 in scope of sonic-net/sonic-swss#2044
After swss module pointer update they will disappear

Dec  7 16:06:33.999613 r-lionfish-16 ERR swss#orchagent: :- objectTypeGetAvailability: attr SAI_L2MC_ENTRY_ATTR_PACKET_ACTION is not resource type
Dec  7 16:06:33.999613 r-lionfish-16 ERR swss#orchagent: :- getResAvailableCounters: Failed to get availability for object_type 53 , rv:-5

[zhangyanzhao]

Need Intel team to take a look, SRv6 related

[prsunny]

@kperumalbfn , please fix