Skip to content

Commit e9d3858

Browse files
antony-rheneuslguohan
authored andcommitted
[build] Fixes for multi arch in Dockerfile (#3237)
Fix for rules/config as it is overridden by Make infra Signed-off-by: Antony Rheneus <[email protected]>
1 parent 6add944 commit e9d3858

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

Makefile.work

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ endif
5353
docker_min := 17.06.1
5454
docker_min_ver := $(shell echo "$(docker_min)" | awk -F. '{printf("%d%03d%03d\n",$$1,$$2,$$3);}' 2>/dev/null)
5555
docker_ver := $(shell docker info 2>/dev/null | grep -i "server version" | rev | cut -d' ' -f1 | rev | awk -F. '{printf("%d%03d%03d\n",$$1,$$2,$$3);}' 2>/dev/null)
56-
docker_is_valid := $(shell if [ $(docker_ver) -lt $(docker_min_ver) ] ; then echo "0"; else echo "1"; fi)
56+
docker_is_valid := $(shell if [[ "$(docker_ver)" -lt $(docker_min_ver) ]] ; then echo "0"; else echo "1"; fi)
5757
ifeq (0,$(docker_is_valid))
5858
$(error SONiC requires Docker version $(docker_min) or later)
5959
endif

slave.mk

+2-1
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,8 @@ list :
8181
## Include other rules
8282
###############################################################################
8383

84+
include $(RULES_PATH)/config
85+
8486
ifeq ($(SONIC_ENABLE_PFCWD_ON_START),y)
8587
ENABLE_PFCWD_ON_START = y
8688
endif
@@ -97,7 +99,6 @@ ifeq ($(SONIC_INSTALL_DEBUG_TOOLS),y)
9799
INSTALL_DEBUG_TOOLS = y
98100
endif
99101

100-
include $(RULES_PATH)/config
101102
include $(RULES_PATH)/functions
102103
include $(RULES_PATH)/*.mk
103104
ifneq ($(CONFIGURED_PLATFORM), undefined)

sonic-slave/Dockerfile.j2

+1-1
Original file line numberDiff line numberDiff line change
@@ -360,6 +360,6 @@ RUN apt-get install -y docker-ce=18.06.3~ce~3-0~debian
360360
RUN echo "DOCKER_OPTS=\"--experimental --storage-driver=vfs\"" >> /etc/default/docker
361361

362362
# For jenkins slave
363-
RUN echo "deb [arch=amd64] http://archive.debian.org/debian jessie-backports main" >> /etc/apt/sources.list
363+
RUN echo "deb [arch={{ CONFIGURED_ARCH }}] http://archive.debian.org/debian jessie-backports main" >> /etc/apt/sources.list
364364
RUN apt-get -o Acquire::Check-Valid-Until=false update
365365
RUN apt-get -y -o Acquire::Check-Valid-Until=false install ca-certificates-java=20161107~bpo8+1 openjdk-8-jdk

0 commit comments

Comments
 (0)