You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The approach this package takes to getting poetry dependencies predates a lot of major improvements which have been made to rules_python. I've made a sort of reference implementation here of what poetry support with the latest rules_python could look like here: https://github.com/AndrewGuenther/rules_python_poetry
In total, it's under 30 lines of code and it works quite smoothly. Compared to the relatively significant size of this implementation, I just don't see a compelling reason for this project to continue. To be clear, this isn't a shot at the maintainers here. I used this package for a long time and have made some contributions of my own, but the Bazel Python ecosystem has evolved past the need for much of the complexity here.
The text was updated successfully, but these errors were encountered:
The approach this package takes to getting poetry dependencies predates a lot of major improvements which have been made to rules_python. I've made a sort of reference implementation here of what poetry support with the latest rules_python could look like here: https://github.com/AndrewGuenther/rules_python_poetry
In total, it's under 30 lines of code and it works quite smoothly. Compared to the relatively significant size of this implementation, I just don't see a compelling reason for this project to continue. To be clear, this isn't a shot at the maintainers here. I used this package for a long time and have made some contributions of my own, but the Bazel Python ecosystem has evolved past the need for much of the complexity here.
This is indeed much simpler!
I was wondering if/how your solution handles different platforms? I think we need to do an export per platform?
Additionally, perhaps your method should be merged into this repo?
The approach this package takes to getting poetry dependencies predates a lot of major improvements which have been made to
rules_python
. I've made a sort of reference implementation here of what poetry support with the latestrules_python
could look like here: https://github.com/AndrewGuenther/rules_python_poetryIn total, it's under 30 lines of code and it works quite smoothly. Compared to the relatively significant size of this implementation, I just don't see a compelling reason for this project to continue. To be clear, this isn't a shot at the maintainers here. I used this package for a long time and have made some contributions of my own, but the Bazel Python ecosystem has evolved past the need for much of the complexity here.
The text was updated successfully, but these errors were encountered: