Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use typing instead of old package to fix a DepShield issue #60

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

DarthHater
Copy link
Member

Quick lil dependency update to sidestep #16 , this switches to using the typings dependency for vscode, which drags in no dependencies, just types :)

Fixes: #16

Copy link
Contributor

@allenhsieh allenhsieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- building and running locally just fine.

image

@DarthHater DarthHater merged commit 21a61d1 into master Nov 26, 2019
@DarthHater DarthHater deleted the FixVsCode branch November 26, 2019 21:23
bhamail pushed a commit that referenced this pull request Nov 26, 2019
## [0.2.4](v0.2.3...v0.2.4) (2019-11-26)

### Bug Fixes

* to use typing instead of old package to fix a DepShield issue ([#60](#60)) ([21a61d1](21a61d1))
@bhamail
Copy link
Contributor

bhamail commented Nov 26, 2019

🎉 This PR is included in version 0.2.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DepShield] (CVSS 7.5) Vulnerability due to usage of mocha:5.2.0
3 participants