Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Waivers are not reflected in the plugin #199

Open
roger-lau opened this issue Apr 9, 2021 · 3 comments
Open

[BUG] Waivers are not reflected in the plugin #199

roger-lau opened this issue Apr 9, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@roger-lau
Copy link
Contributor

Describe the bug
When a waiver is applied in Nexus IQ Server, the waiver is not reflected in the plugin.

To Reproduce
Steps to reproduce the behavior:

  1. Load the plugin in VS Code
  2. Look for a component with security-critical violation in the plugin, e.g. execa 1.0.0
  3. Copy the report link from the plugin
  4. Open report link in browser
  5. Waive security-critical violation in execa 1.0.0
  6. Re-evaluate report
  7. Check the report and see that it is already waived and shows as no violation
  8. Go back to VS Code, refresh the plugin using the refresh button
  9. execa 1.0.0 still shows as a violation
  10. Close VS Code, re-open again.
  11. execa 1.0.0 still shows as a violation

Expected behavior
Waived components should not show as a violation in the plugin

Desktop (please complete the following information):

  • OS: Windows
  • NodeJS Version: No info
  • VS Code Version: No info
  • Version of Extension: Freshly installed

Additional context
ApplicationId used in VS Code matches the Application that was waived in IQ Server.

cc @bhamail / @DarthHater

@roger-lau roger-lau added the bug Something isn't working label Apr 9, 2021
@DarthHater
Copy link
Member

I will have to take a gander at this. Thanks for reporting @roger-lau !

@DarthHater DarthHater self-assigned this Apr 10, 2021
@madpah
Copy link
Collaborator

madpah commented Jan 17, 2022

@roger-lau - can you confirm if this is still and issue with plugin version 1.2.3 please?

@roger-lau
Copy link
Contributor Author

@madpah I just ran it again, with v1.2.3. It is still not reflecting the waiver status in the VS Code. When I go into the report, the waiver persisted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants