Merge Process Environment on Exec Calls #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @jpm63 to sign the Sonatype Contributor License Agreement. |
DarthHater
reviewed
Mar 16, 2021
|
|
||
| export function exec(command: string, options: cp.ExecOptions): Promise<{ stdout: string; stderr: string }> { | ||
| options.env = { ...process.env, ...options.env } |
There was a problem hiding this comment.
Neato!
Also isn't process just available (no import needed?): https://github.com/sonatype-nexus-community/vscode-iq-plugin/pull/187/files#diff-c95f6239f1374b3dc1be4cafeaf71efac187b103786c2466678b43b8c0e5d9bcR52-R54
There was a problem hiding this comment.
Good call - I've removed the import
jpm63
changed the title
|
Thanks a ton for the PR! We really appreciate it!!! This should be released momentarily :) |
brent-spiner
pushed a commit
that referenced
this pull request
Mar 24, 2021
## [1.0.23](v1.0.22...v1.0.23) (2021-03-24) ### Bug Fixes * Merge Process Environment on Exec Calls ([#192](#192)) ([7eaa72f](7eaa72f))
|
🎉 This PR is included in version 1.0.23 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure any
execcalls to use the VS Code process's environment variables in addition to any plugin-provided overrides.This pull request makes the following changes:
Adjusts the
execfunction to incorporate VS Code process's environment variables.(If there are changes to user behavior in general, please make sure to
update the docs, as well)
It relates to the following issue #s:
cc @bhamail / @DarthHater