Add poetry.lock file to the theseAreTheLockFilesIKnow array in ConanU… #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhamail
approved these changes
Jan 22, 2021
There was a problem hiding this comment.
LGTM.
If we only had a unit test framework to validate. ;) It might be worth adding some simple notes to the PR to make it easier to add a test later. Basically what it took to reproduce the bug:
- Python project with
poetry.lockfile. - ...
- Error with a message like: yadda yadda
Even if we never get a test for the issue, more info in the PR might help others to find this PR (via the details of the bug) and know they should upgrade to fix it.
brent-spiner
pushed a commit
that referenced
this pull request
Jan 22, 2021
## [1.0.12](v1.0.11...v1.0.12) (2021-01-22) ### Bug Fixes * Add poetry.lock file to the theseAreTheLockFilesIKnow array in ConanUtils.ts ([#179](#179)) ([9780711](9780711))
|
🎉 This PR is included in version 1.0.12 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conan format no longer mistakes a
poetry.lockexisting in a Python project for a conan lock file.This pull request makes the following changes:
poetry.lockfile to the known .lock files dependency list in ConanUtils.tscc @bhamail / @DarthHater @ButterB0wl