Add component stack to previously missed hydrate warnings (facebook#1…

…0085)
sompylasar · Jun 8, 2018 · 4e42d23 · 4e42d23
1 parent 28cbe05
commit 4e42d23
Show file tree

Hide file tree

Showing 2 changed files with 100 additions and 83 deletions.
diff --git a/packages/react-dom/src/client/ReactDOMFiberComponent.js b/packages/react-dom/src/client/ReactDOMFiberComponent.js
@@ -1128,9 +1128,10 @@ export function warnForDeletedHydratableElement(
     didWarnInvalidHydration = true;
     warning(
       false,
-      'Did not expect server HTML to contain a <%s> in <%s>.',
+      'Did not expect server HTML to contain a <%s> in <%s>.%s',
       child.nodeName.toLowerCase(),
       parentNode.nodeName.toLowerCase(),
+      getStack(),
     );
   }
 }
@@ -1146,9 +1147,10 @@ export function warnForDeletedHydratableText(
     didWarnInvalidHydration = true;
     warning(
       false,
-      'Did not expect server HTML to contain the text node "%s" in <%s>.',
+      'Did not expect server HTML to contain the text node "%s" in <%s>.%s',
       child.nodeValue,
       parentNode.nodeName.toLowerCase(),
+      getStack(),
     );
   }
 }
@@ -1191,9 +1193,10 @@ export function warnForInsertedHydratedText(
     didWarnInvalidHydration = true;
     warning(
       false,
-      'Expected server HTML to contain a matching text node for "%s" in <%s>.',
+      'Expected server HTML to contain a matching text node for "%s" in <%s>.%s',
       text,
       parentNode.nodeName.toLowerCase(),
+      getStack(),
     );
   }
 }