Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Issue | Excessive if/else checks in data parsing module #210

Open
manik96m opened this issue Apr 12, 2020 · 1 comment
Open

Performance Issue | Excessive if/else checks in data parsing module #210

manik96m opened this issue Apr 12, 2020 · 1 comment

Comments

@manik96m
Copy link
Contributor

Describe the bug
There are excessive if/else checks in the data parsing module which is the reason why the website is taking more time to reflect the data on the first load and also when the data is fetched again(triggered from the header.js and DataPicker.js)

To Reproduce

  1. Go to 'https://cluster.covid19india.org/'
  2. Try changing the date or updating the checkbox in the header.
  3. It takes a very long time to reflect on the latest fetched data.

Expected behavior
The parsing of the data can be improved to increase performance.

Desktop:

  • OS: MacOS
  • Browser: chrome
  • Version: 80.0.3987.149
@manik96m
Copy link
Contributor Author

have added a fix in this PR. Please check.

@manik96m manik96m mentioned this issue Apr 12, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@manik96m