Fix/init #45
Closed
Fix/init #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plrdev
reviewed
Jun 14, 2019
readme.md
Outdated
| @@ -66,6 +66,9 @@ module.exports = { | |||
| repo: "github-repo", | |||
| circleApi: "circleApiToken", | |||
| googleJsonPath: "path/to/google/json", | |||
| storePassword: "password", | |||
There was a problem hiding this comment.
These could be prefixed as keystore, so keystorePassword, keystoreAlias keystoreAliasPassword or something like that so it is clear that they are related.
src/flows/android.js
Outdated
| return { | ||
| googleJsonPath: options.googleJsonPath, | ||
| googleJsonPath | ||
| const askStorePassword = { |
There was a problem hiding this comment.
It would be great to first make sure that user wants to create a keystore and only then asks these.
There was a problem hiding this comment.
I just ran into this as my existing configuration got mangled; for existing apps, prompting for existing keystore configurations would be great.
| @@ -29,7 +32,7 @@ const askQuestions = async ({ prompt }, options) => { | |||
| } | |||
| // ask a series of questions | |||
| const questions = [askOrganization, askProject, askApiToken] | |||
| const answers = prompt.ask(questions) | |||
| const answers = await prompt.ask(questions) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8 #44