Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diamond beacon proxy implementation #229

Open
ItsNickBarry opened this issue Oct 12, 2023 · 0 comments · May be fixed by #233
Open

Add diamond beacon proxy implementation #229

ItsNickBarry opened this issue Oct 12, 2023 · 0 comments · May be fixed by #233

Comments

@ItsNickBarry
Copy link
Member

The diamond beacon proxy pattern that we've been using and recommending is not minimal, and includes some features that are non-functional in the context of proxies which reference the beacon. A proper beacon should include DiamondReadable and DiamondWritable, but not DiamondBase. A SolidStateDiamond should not be used as a beacon because it includes DiamondBase and several other extensions.
@ItsNickBarry ItsNickBarry linked a pull request Jan 28, 2024 that will close this issue
Beacon patterns #233
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Beacon patterns solidstate-network/solidstate-solidity
1 participant
@ItsNickBarry