Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding a service's name #47

Merged
merged 1 commit into from
Nov 12, 2014
Merged

Allow overriding a service's name #47

merged 1 commit into from
Nov 12, 2014

Conversation

jsok
Copy link
Contributor

@jsok jsok commented Nov 12, 2014

Implement suggested fix in #46

@EvanKrall
Copy link
Contributor

👍 looks good to me. This will break backwards compatibility for anybody who was passing name explicitly before, but I don't think that's a big deal.

solarkennedy added a commit that referenced this pull request Nov 12, 2014
@solarkennedy
Merge pull request #47 from jsok/service-name-aliasing-fix
9c8168a 
Allow overriding a service's name
@solarkennedy solarkennedy merged commit 9c8168a into voxpupuli:master Nov 12, 2014
@solarkennedy
Copy link
Contributor

Thanks! Closes #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsok @EvanKrall @solarkennedy