Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure log file for upstart. #265

Merged
merged 1 commit into from
Jun 15, 2016
Merged

Configure log file for upstart. #265

merged 1 commit into from
Jun 15, 2016

Conversation

jdavisp3
Copy link

This PR configures a log file for the upstart configuration similar to the one for the init.d configuration.

I tested this by provisioning a consul server with the new configuration and observing the log file being created log entries being appended. I restarted the service and the new entries were appended to the existing file.

@solarkennedy
Copy link
Contributor

But if you are running consul as non-root, will it be able to continue to log? I guess it doesn't really log to a file anyway.

@solarkennedy solarkennedy merged commit 7011708 into voxpupuli:master Jun 15, 2016
@jdavisp3
Copy link
Author

Thanks for taking my contribution!

But if you are running consul as non-root, will it be able to continue to log? I guess it doesn't really log to a file anyway.

In my test setup the consul Java process does not run as root but it is able to log to the file. The upstart configuration will create the log file as root and set up the I/O redirection before launching the start-stop-daemon process which switches to the consul user.

Note this configuration does log to a file: /var/log/consul.

@jdavisp3 jdavisp3 deleted the upstart-log-file branch June 15, 2016 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants