Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Update rust-bpf-builder to be based on Rust 1.40 or above #11055

Closed
Aaron1011 opened this issue Jul 14, 2020 · 4 comments
Closed

Update rust-bpf-builder to be based on Rust 1.40 or above #11055

Aaron1011 opened this issue Jul 14, 2020 · 4 comments
Assignees
Milestone

Comments

@Aaron1011
Copy link
Contributor

Currently, rust-bpf-builder uses a custom version of Rust based on Rust 1.39: https://github.com/solana-labs/rust-bpf-builder/blob/2ae3f921f65789067963b7d7a41219d0a1997edb/linux/Dockerfile#L66-L69

In Rust 1.40, procedural macros can expand to macro_rules! declaration without using #![feature(proc_macro_hygiene)]. By basing rust-bpf-builder on a newer version of Rust, we can avoid the need to conditionally apply the #![feature(proc_macro_hygiene)] feature gate in #10905

@garious
Copy link
Contributor

garious commented Jul 22, 2020

@jackcmay ^^^

@jackcmay
Copy link
Contributor

@garious Yup

@mvines mvines added this to the v1.4.0 milestone Aug 18, 2020
@Lichtso
Copy link
Contributor

Lichtso commented Sep 7, 2020

I rebased the BPF patches onto Rust 1.46
anza-xyz/rust#2
https://github.com/solana-labs/rust/tree/solana-1.46
https://github.com/solana-labs/llvm-project/tree/solana-rustc/10.0-2020-05-05

It still compiles on macOS, but I haven't done any further testing yet.

@mvines mvines modified the milestones: v1.4.0, v1.5.0 Oct 8, 2020
@mvines mvines modified the milestones: v1.5.0, v1.6.0 Dec 17, 2020
@jackcmay
Copy link
Contributor

jackcmay commented Mar 3, 2021

Rust v1.46 is planned for Solana v1.6 and support for v1.50 and incremental upgrades after is in the works

@jackcmay jackcmay closed this as completed Mar 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants