Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use $crate instead of ::solana_sdk in declare_name! macro #10933

Closed
Aaron1011 opened this issue Jul 6, 2020 · 0 comments · Fixed by #11326
Closed

Use $crate instead of ::solana_sdk in declare_name! macro #10933

Aaron1011 opened this issue Jul 6, 2020 · 0 comments · Fixed by #11326

Comments

@Aaron1011
Copy link
Contributor

In #10905, I needed to use ::solana_sdk as a path in a macro, since a rustc issue prevents $crate from working properly. Once rust-lang/rust#72121 is merged, we can switch to using $crate
@Aaron1011 Aaron1011 mentioned this issue Jul 6, 2020
Merged
Aaron1011 added a commit to Aaron1011/solana that referenced this issue Aug 1, 2020
@Aaron1011
Bump Rust nightly to 2020-07-31 and remove ::solana_sdk hack
609e4b2 
Fixes solana-labs#10933

Now that rust-lang/rust#72121 has been merged,
using a `$crate` path from a nested `macro_rules!` will work properly
across multiple crates. This allows us to update to a nightly build
containing this PR, and stop using `::solana_sdk` to refer to the
`respan!` macro.
@Aaron1011 Aaron1011 mentioned this issue Aug 1, 2020
Merged
Aaron1011 added a commit to Aaron1011/solana that referenced this issue Aug 4, 2020
@Aaron1011
Remove ::solana_sdk hack
3a8af68 
Fixes solana-labs#10933

Now that rust-lang/rust#72121 has been merged,
using a `$crate` path from a nested `macro_rules!` will work properly
across multiple crates. This allows us to stop using `::solana_sdk`
to reference to the `respan!` macro.
Aaron1011 added a commit to Aaron1011/solana that referenced this issue Aug 18, 2020
@Aaron1011
Remove ::solana_sdk hack
0ee7e2a 
Fixes solana-labs#10933

Now that rust-lang/rust#72121 has been merged,
using a `$crate` path from a nested `macro_rules!` will work properly
across multiple crates. This allows us to stop using `::solana_sdk`
to reference to the `respan!` macro.
@mergify mergify bot closed this as completed in #11326 Aug 18, 2020
mergify bot pushed a commit that referenced this issue Aug 18, 2020
@Aaron1011
Remove ::solana_sdk hack (#11326)
c099b29 
Fixes #10933

Now that rust-lang/rust#72121 has been merged,
using a `$crate` path from a nested `macro_rules!` will work properly
across multiple crates. This allows us to stop using `::solana_sdk`
to reference to the `respan!` macro.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove ::solana_sdk hack Aaron1011/solana
1 participant
@Aaron1011