Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD workflow doesn't work with Node 20 #1786

Closed
mcintyre94 opened this issue Oct 26, 2023 · 2 comments
Closed

CI/CD workflow doesn't work with Node 20 #1786

mcintyre94 opened this issue Oct 26, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@mcintyre94
Copy link
Contributor

The CICD workflow started failing when the lts/* node version bumped from 18.x to 20.x: https://github.com/solana-labs/solana-web3.js/actions/runs/6640521649/job/18041101940

This is temporarily resolved by locking the Node version on this workflow to 18.x

This is caused by code in version-from-git that doesn't work on Node 20: compulim/version-from-git#16

version-from-git is unmaintained, with the last commit 4 years ago and a PR fixing this issue open since 31st August

We will need to fork it, or find an updated fork, and use that instead. Then we can bump our CICD workflow to Node 20.

@steveluscher
Copy link
Collaborator

We no longer use version-from-git. Problem solved.

Copy link
Contributor

Because there has been no activity on this issue for 7 days since it was closed, it has been automatically locked. Please open a new issue if it requires a follow up.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants