Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix templates indentations #81

Open
jibidus opened this issue Nov 29, 2019 · 6 comments
Open

Fix templates indentations #81

jibidus opened this issue Nov 29, 2019 · 6 comments
Assignees
Labels
chore Side task

Comments

@jibidus
Copy link
Contributor

jibidus commented Nov 29, 2019

No description provided.

@jibidus jibidus added chore Side task good first issue Good for newcomers labels Nov 29, 2019
@JulioJu
Copy link
Contributor

JulioJu commented Dec 7, 2019

Hi @jibidus , what do you mean with this issue ? Thanks in advance :-)

@jibidus
Copy link
Contributor Author

jibidus commented Dec 9, 2019

html templates are not all well formatted.

Example (footer.html):

<svg version="1.1"
   xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:a="http://ns.adobe.com/AdobeSVGViewerExtensions/3.0/"
   x="0px" y="0px" width="25.2px" height="24px" viewBox="0 0 25.2 24" style="enable-background:new 0 0 25.2 24;"
   xml:space="preserve">
<defs>
   </defs>
<path id="ico_linkedin_1_" class="st0" d="M25.2,14.7V24h-5.4v-8.7c0-2.2-0.8-3.7-2.7-3.7c-1.2,0-2.4,0.8-2.8,2
 c-0.1,0.4-0.2,0.9-0.2,1.3V24H8.7c0,0,0.1-14.7,0-16.2h5.4v2.3l0,0.1h0v-0.1c1-1.7,2.9-2.8,4.9-2.7C22.5,7.4,25.2,9.8,25.2,14.7z
 M3.1,0C1.5-0.1,0.2,1,0,2.6s1,2.9,2.5,3.1c0.1,0,0.3,0,0.4,0h0c1.5,0.1,2.9-1,3.1-2.5S5.1,0.2,3.5,0C3.4,0,3.2,0,3.1,0z M0.3,24
 h5.4V7.8H0.3V24z"/>
 </svg>

should be fixed with:

<svg version="1.1"
   xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" xmlns:a="http://ns.adobe.com/AdobeSVGViewerExtensions/3.0/"
   x="0px" y="0px" width="25.2px" height="24px" viewBox="0 0 25.2 24" style="enable-background:new 0 0 25.2 24;"
   xml:space="preserve">
<defs>
</defs>
<path id="ico_linkedin_1_" class="st0" d="M25.2,14.7V24h-5.4v-8.7c0-2.2-0.8-3.7-2.7-3.7c-1.2,0-2.4,0.8-2.8,2
   c-0.1,0.4-0.2,0.9-0.2,1.3V24H8.7c0,0,0.1-14.7,0-16.2h5.4v2.3l0,0.1h0v-0.1c1-1.7,2.9-2.8,4.9-2.7C22.5,7.4,25.2,9.8,25.2,14.7z
   M3.1,0C1.5-0.1,0.2,1,0,2.6s1,2.9,2.5,3.1c0.1,0,0.3,0,0.4,0h0c1.5,0.1,2.9-1,3.1-2.5S5.1,0.2,3.5,0C3.4,0,3.2,0,3.1,0z M0.3,24
   h5.4V7.8H0.3V24z"/>
 </svg>

@JulioJu
Copy link
Contributor

JulioJu commented Dec 9, 2019

@jibidus un petit coup de prettier ;-) ? Je me l'assigne, je m'en occupe mercredi j'espère ;-)

@JulioJu JulioJu self-assigned this Dec 9, 2019
@JulioJu
Copy link
Contributor

JulioJu commented Dec 15, 2019

J'attends que y'ait quelques PR qui soient mergées, parce que sinon ça sent le conflit de merge à plein nez ! Vu que c'est facile à faire, j'attends ;-)

@JulioJu JulioJu removed the good first issue Good for newcomers label Dec 29, 2019
@JulioJu
Copy link
Contributor

JulioJu commented Dec 29, 2019

Please do not do that, cause of risks of merge conflicts. I will do that when I will finish. Very easy to do.

@JulioJu
Copy link
Contributor

JulioJu commented May 10, 2020

Could not work with Prettier. See #160 .

Will work if we change Hugo to VuePress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Side task
Projects
None yet
Development

No branches or pull requests

2 participants