Skip to content

Conversation

@kkafar
Copy link
Member

@kkafar kkafar commented Apr 11, 2025

@kkafar kkafar force-pushed the @kkafar/deployment-target-for-tvos branch from 4a6a197 to 8ef1e78 Compare April 11, 2025 13:40
@kkafar kkafar self-assigned this Apr 11, 2025
Copy link
Contributor

@maciekstosio maciekstosio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, rest looks good


new_arch_enabled = ENV['RCT_NEW_ARCH_ENABLED'] == '1'
min_supported_ios_version = new_arch_enabled ? "15.1" : "15.1"
min_supported_tvos_version = "15.1"
Copy link
Contributor

@maciekstosio maciekstosio Apr 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need new_arch_enabled ? (...) above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I justified it in description of: #2799

@kkafar kkafar merged commit 8360b4f into main Apr 11, 2025
5 of 6 checks passed
@kkafar kkafar deleted the @kkafar/deployment-target-for-tvos branch April 11, 2025 13:44
kkafar added a commit that referenced this pull request Apr 11, 2025
## Description

Followup to
#2862 after
#2863 is
merged.

## Changes

- **Cleanup in RNSScreenStackHeaderConfig**

## Test code and steps to reproduce

Build

## Checklist

- [ ] Ensured that CI passes
Copy link
Contributor

@kligarski kligarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants