Skip to content

Commit 1f05c0c

Browse files
committed
Require
1 parent 133378f commit 1f05c0c

File tree

3 files changed

+3
-28
lines changed

3 files changed

+3
-28
lines changed

android/src/main/java/com/swmansion/rnscreens/bottomsheet/BottomSheetMetrics.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ fun getSheetMetrics(
1212
screen: Screen,
1313
availableHeight: Int,
1414
sheetHeight: Int,
15-
): BottomSheetMetrics? {
16-
if (!screen.usesFormSheetPresentation()) {
17-
return null
15+
): BottomSheetMetrics {
16+
require(screen.usesFormSheetPresentation()) {
17+
"[RNScreens] Expected screen to use form sheet presentation"
1818
}
1919

2020
val maxDetent = screen.sheetDetents.lastOrNull() ?: 1.0

android/src/main/java/com/swmansion/rnscreens/bottomsheet/SheetDelegate.kt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import com.swmansion.rnscreens.KeyboardState
1919
import com.swmansion.rnscreens.KeyboardVisible
2020
import com.swmansion.rnscreens.Screen
2121
import com.swmansion.rnscreens.ScreenStackFragment
22-
import com.swmansion.rnscreens.utils.RNSLog
2322

2423
class SheetDelegate(
2524
val screen: Screen,
@@ -278,11 +277,6 @@ class SheetDelegate(
278277
sheetHeight = screen.height,
279278
)
280279

281-
if (metrics == null) {
282-
RNSLog.w("[RNScreens]", "Sheet metrics were not defined for the screen that's expected to be the sheet")
283-
return insets
284-
}
285-
286280
val newTopInset =
287281
if (screen.isOverflowingStatusBar(prevInsets.top, metrics) && !isImeVisible) {
288282
prevInsets.top - (metrics.availableHeight - metrics.maxSheetHeight)

android/src/main/java/com/swmansion/rnscreens/utils/RNSLog.kt

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -22,23 +22,4 @@ object RNSLog {
2222
Log.d(tag, message.format(*args))
2323
}
2424
}
25-
26-
fun w(
27-
tag: String,
28-
message: String,
29-
) {
30-
if (BuildConfig.RNS_DEBUG_LOGGING) {
31-
Log.w(tag, message)
32-
}
33-
}
34-
35-
fun w(
36-
tag: String,
37-
message: String,
38-
vararg args: Any,
39-
) {
40-
if (BuildConfig.RNS_DEBUG_LOGGING) {
41-
Log.w(tag, message.format(*args))
42-
}
43-
}
4425
}

0 commit comments

Comments
 (0)