refactor(Worklets): move JSScheduler #6762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
force-pushed
the
@tjzel/worklets/move-js-scheduler
branch
from
a24c83c to
e7eb4a2
Compare
tjzel
added
the
Check compatibility
tjzel
commented
Dec 4, 2024
tomekzaw
reviewed
Dec 4, 2024
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/ReanimatedModuleProxy.cpp
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/ReanimatedModuleProxy.cpp
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/ReanimatedModuleProxy.cpp
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/ReanimatedModuleProxy.h
Show resolved
Hide resolved
piaskowyk
approved these changes
Dec 5, 2024
Member
piaskowyk
left a comment
piaskowyk
left a comment
There was a problem hiding this comment.
With the additional explanation that every turbo module has its own reference to the JS call invoker, and that this change is to leverage their own reference instead of cross-passing, this change makes sense to me. However, before we proceed with the merge, let's consider Tomek's comments.
tomekzaw
approved these changes
Dec 9, 2024
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
## Summary This pull requests moves `JSScheduler`, a class responsible for scheduling operations back to the JavaScript thread, to Worklets. - `JSScheduler` is now available from `WorkletsModuleProxy` in cpp and that's how `ReanimatedModuleProxy` obtains it when it needs it. More sophisticated APIs will be made in the future. - Both `ReanimatedModule` and `WorkletsModule` are now responsible to forward `jsCallInvoker` to their own Proxy modules. `jsCallInvoker` is no longer available in `JSScheduler`. ## Test plan CI
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
## Summary This pull requests moves `JSScheduler`, a class responsible for scheduling operations back to the JavaScript thread, to Worklets. - `JSScheduler` is now available from `WorkletsModuleProxy` in cpp and that's how `ReanimatedModuleProxy` obtains it when it needs it. More sophisticated APIs will be made in the future. - Both `ReanimatedModule` and `WorkletsModule` are now responsible to forward `jsCallInvoker` to their own Proxy modules. `jsCallInvoker` is no longer available in `JSScheduler`. ## Test plan CI
tjzel
added a commit
that referenced
this pull request
Dec 13, 2024
## Summary This pull requests moves `JSScheduler`, a class responsible for scheduling operations back to the JavaScript thread, to Worklets. - `JSScheduler` is now available from `WorkletsModuleProxy` in cpp and that's how `ReanimatedModuleProxy` obtains it when it needs it. More sophisticated APIs will be made in the future. - Both `ReanimatedModule` and `WorkletsModule` are now responsible to forward `jsCallInvoker` to their own Proxy modules. `jsCallInvoker` is no longer available in `JSScheduler`. ## Test plan CI
r0h0gg6
pushed a commit
to r0h0gg6/react-native-reanimated
that referenced
this pull request
Jul 28, 2025
## Summary This pull requests moves `JSScheduler`, a class responsible for scheduling operations back to the JavaScript thread, to Worklets. - `JSScheduler` is now available from `WorkletsModuleProxy` in cpp and that's how `ReanimatedModuleProxy` obtains it when it needs it. More sophisticated APIs will be made in the future. - Both `ReanimatedModule` and `WorkletsModule` are now responsible to forward `jsCallInvoker` to their own Proxy modules. `jsCallInvoker` is no longer available in `JSScheduler`. ## Test plan CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull requests moves
JSScheduler, a class responsible for scheduling operations back to the JavaScript thread, to Worklets.JSScheduleris now available fromWorkletsModuleProxyin cpp and that's howReanimatedModuleProxyobtains it when it needs it. More sophisticated APIs will be made in the future.ReanimatedModuleandWorkletsModuleare now responsible to forwardjsCallInvokerto their own Proxy modules.jsCallInvokeris no longer available inJSScheduler.Test plan
CI