From 5287b702436afc2738f51d2a6480e2238bc564a7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20=C5=BBelawski?= Date: Fri, 25 Oct 2024 13:24:11 +0200 Subject: [PATCH 01/13] fix: Installation of Reanimated from commit --- .github/workflows/V8-reanimated-build-check-nightly.yml | 2 +- .../react-native-nightly-reanimated-build-check-nightly.yml | 2 +- .github/workflows/reanimated-compatibility-check-nightly.yml | 2 +- .../static-framework-reanimated-build-check-nightly.yml | 2 +- .../windows-hosted-app-reanimated-build-check-nightly.yml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/V8-reanimated-build-check-nightly.yml b/.github/workflows/V8-reanimated-build-check-nightly.yml index 15eb001587f7..9aa397fc6c0f 100644 --- a/.github/workflows/V8-reanimated-build-check-nightly.yml +++ b/.github/workflows/V8-reanimated-build-check-nightly.yml @@ -35,7 +35,7 @@ jobs: run: yarn install - name: Install Reanimated working-directory: app - run: yarn add react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#commit=${{ github.sha }} + run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}" - name: Install test dependencies working-directory: app run: yarn add react-native-v8 v8-android-jit diff --git a/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml b/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml index 9b7f2d332919..435e5aae348a 100644 --- a/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml +++ b/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml @@ -51,7 +51,7 @@ jobs: run: touch yarn.lock - name: Install Reanimated working-directory: ${{ env.APP_NAME }} - run: yarn add react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#commit=${{ github.sha }} + run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}" - name: Install Paper Pods (iOS) if: ${{ matrix.react-native-architecture == 'Paper' && matrix.platform == 'iOS' }} working-directory: app/ios diff --git a/.github/workflows/reanimated-compatibility-check-nightly.yml b/.github/workflows/reanimated-compatibility-check-nightly.yml index 0a7008f05b29..1c3b46983a89 100644 --- a/.github/workflows/reanimated-compatibility-check-nightly.yml +++ b/.github/workflows/reanimated-compatibility-check-nightly.yml @@ -53,7 +53,7 @@ jobs: run: corepack enable && yarn set version berry - name: Install Reanimated working-directory: ${{ env.APP_NAME }} - run: yarn add react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#commit=${{ github.sha }} + run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}" - name: Install Pods if: ${{ matrix.platform == 'iOS' }} working-directory: ${{ env.APP_NAME }}/ios diff --git a/.github/workflows/static-framework-reanimated-build-check-nightly.yml b/.github/workflows/static-framework-reanimated-build-check-nightly.yml index db3fa5510f48..b7cff8b68ede 100644 --- a/.github/workflows/static-framework-reanimated-build-check-nightly.yml +++ b/.github/workflows/static-framework-reanimated-build-check-nightly.yml @@ -26,7 +26,7 @@ jobs: run: npx react-native init app - name: Install Reanimated working-directory: app - run: yarn add react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#commit=${{ github.sha }} + run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}" - name: Install Paper Pods if: ${{ matrix.react-native-architecture == 'Paper' }} working-directory: app/ios diff --git a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml index f672cb2d58ac..060a60f3718b 100644 --- a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml +++ b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml @@ -30,7 +30,7 @@ jobs: run: yarn - name: Install Reanimated working-directory: app - run: yarn add react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#commit=${{ github.sha }} + run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}" - name: Build Android App working-directory: app/android run: ./gradlew assembleDebug --console=plain From 4cedba07a1eb89b781fbbe7a5f3e3cf3b0dfd962 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20=C5=BBelawski?= Date: Fri, 25 Oct 2024 13:46:30 +0200 Subject: [PATCH 02/13] chore: Use Yarn Modern --- .../V8-reanimated-build-check-nightly.yml | 19 ++++++++++++------- ...nightly-reanimated-build-check-nightly.yml | 7 +++++-- ...ted-app-reanimated-build-check-nightly.yml | 13 +++++++++---- 3 files changed, 26 insertions(+), 13 deletions(-) diff --git a/.github/workflows/V8-reanimated-build-check-nightly.yml b/.github/workflows/V8-reanimated-build-check-nightly.yml index 9aa397fc6c0f..a204542116c5 100644 --- a/.github/workflows/V8-reanimated-build-check-nightly.yml +++ b/.github/workflows/V8-reanimated-build-check-nightly.yml @@ -18,6 +18,8 @@ jobs: concurrency: group: build-v8-${{ github.ref }} cancel-in-progress: true + env: + APP_NAME: app steps: - name: Check out uses: actions/checkout@v4 @@ -28,19 +30,22 @@ jobs: with: distribution: 'zulu' java-version: '17' - - name: Create React Native app - run: npx react-native init app + - name: Create React Native App + run: npx react-native init ${{ env.APP_NAME }} + - name: Setup Yarn Modern + working-directory: ${{ env.APP_NAME }} + run: corepack enable && yarn set version berry - name: Install dependencies - working-directory: app + working-directory: ${{ env.APP_NAME }} run: yarn install - name: Install Reanimated - working-directory: app + working-directory: ${{ env.APP_NAME }} run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}" - name: Install test dependencies - working-directory: app + working-directory: ${{ env.APP_NAME }} run: yarn add react-native-v8 v8-android-jit - name: Configure V8 run: node reanimated_repo/.github/workflows/helper/configureV8.js - - name: Build Android app - working-directory: app/android + - name: Build Android ${{ env.APP_NAME }} + working-directory: ${{ env.APP_NAME }}/android run: ./gradlew assembleDebug --console=plain diff --git a/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml b/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml index 435e5aae348a..8ea070df025a 100644 --- a/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml +++ b/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml @@ -46,6 +46,9 @@ jobs: - name: Create app run: | yarn react-native init ${{ env.APP_NAME }} --version ${{ env.REACT_NATIVE_TAG }} --pm yarn --skip-install --install-pods false --skip-git-init + - name: Setup Yarn Modern + working-directory: ${{ env.APP_NAME }} + run: yarn set version berry - name: Add yarn.lock in app working-directory: ${{ env.APP_NAME }} run: touch yarn.lock @@ -54,11 +57,11 @@ jobs: run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}" - name: Install Paper Pods (iOS) if: ${{ matrix.react-native-architecture == 'Paper' && matrix.platform == 'iOS' }} - working-directory: app/ios + working-directory: ${{ env.APP_NAME }}/ios run: bundle install && bundle exec pod install - name: Install Fabric Pods (iOS) if: ${{ matrix.react-native-architecture == 'Fabric' && matrix.platform == 'iOS' }} - working-directory: app/ios + working-directory: ${{ env.APP_NAME }}/ios run: RCT_NEW_ARCH_ENABLED=1 bundle install && bundle exec pod install - name: Setup Fabric (Android) if: ${{ matrix.react-native-architecture == 'Fabric' && matrix.platform == 'Android' }} diff --git a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml index 060a60f3718b..4012ad524261 100644 --- a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml +++ b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml @@ -17,6 +17,8 @@ jobs: concurrency: group: build-on-windows-${{ github.ref }} cancel-in-progress: true + env: + APP_NAME: app steps: - name: Set up JDK 17 uses: actions/setup-java@v4 @@ -24,13 +26,16 @@ jobs: distribution: 'zulu' java-version: '17' - name: Create React Native App - run: npx react-native init app + run: npx react-native init ${{ env.APP_NAME }} + - name: Setup Yarn Modern + working-directory: ${{ env.APP_NAME }} + run: corepack enable && yarn set version berry - name: Install dependencies - working-directory: app + working-directory: ${{ env.APP_NAME }} run: yarn - name: Install Reanimated - working-directory: app + working-directory: ${{ env.APP_NAME }} run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}" - name: Build Android App - working-directory: app/android + working-directory: ${{ env.APP_NAME }}/android run: ./gradlew assembleDebug --console=plain From fd61771828c389047083a8e247b34e88a5784bca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20=C5=BBelawski?= Date: Fri, 25 Oct 2024 13:56:56 +0200 Subject: [PATCH 03/13] chore: Add explicit yarn.locks --- .github/workflows/V8-reanimated-build-check-nightly.yml | 4 ++-- .../react-native-nightly-reanimated-build-check-nightly.yml | 5 +---- .../windows-hosted-app-reanimated-build-check-nightly.yml | 4 ++-- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/.github/workflows/V8-reanimated-build-check-nightly.yml b/.github/workflows/V8-reanimated-build-check-nightly.yml index a204542116c5..16e26d20d4ba 100644 --- a/.github/workflows/V8-reanimated-build-check-nightly.yml +++ b/.github/workflows/V8-reanimated-build-check-nightly.yml @@ -31,10 +31,10 @@ jobs: distribution: 'zulu' java-version: '17' - name: Create React Native App - run: npx react-native init ${{ env.APP_NAME }} + run: npx react-native init ${{ env.APP_NAME }} --skip-install - name: Setup Yarn Modern working-directory: ${{ env.APP_NAME }} - run: corepack enable && yarn set version berry + run: touch yarn.lock && corepack enable && yarn set version berry - name: Install dependencies working-directory: ${{ env.APP_NAME }} run: yarn install diff --git a/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml b/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml index 8ea070df025a..f79e44396245 100644 --- a/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml +++ b/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml @@ -48,10 +48,7 @@ jobs: yarn react-native init ${{ env.APP_NAME }} --version ${{ env.REACT_NATIVE_TAG }} --pm yarn --skip-install --install-pods false --skip-git-init - name: Setup Yarn Modern working-directory: ${{ env.APP_NAME }} - run: yarn set version berry - - name: Add yarn.lock in app - working-directory: ${{ env.APP_NAME }} - run: touch yarn.lock + run: touch yarn.lock && yarn set version berry - name: Install Reanimated working-directory: ${{ env.APP_NAME }} run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}" diff --git a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml index 4012ad524261..ed2c2df02b53 100644 --- a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml +++ b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml @@ -26,10 +26,10 @@ jobs: distribution: 'zulu' java-version: '17' - name: Create React Native App - run: npx react-native init ${{ env.APP_NAME }} + run: npx react-native init ${{ env.APP_NAME }} --skip-install - name: Setup Yarn Modern working-directory: ${{ env.APP_NAME }} - run: corepack enable && yarn set version berry + run: touch yarn.lock && corepack enable && yarn set version berry - name: Install dependencies working-directory: ${{ env.APP_NAME }} run: yarn From 29291dc0043fe26371230e9e08d2a6b41c076040 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20=C5=BBelawski?= Date: Fri, 25 Oct 2024 14:03:22 +0200 Subject: [PATCH 04/13] chore: Remove env variables --- .github/workflows/V8-reanimated-build-check-nightly.yml | 2 -- .../react-native-nightly-reanimated-build-check-nightly.yml | 2 -- .../windows-hosted-app-reanimated-build-check-nightly.yml | 2 -- 3 files changed, 6 deletions(-) diff --git a/.github/workflows/V8-reanimated-build-check-nightly.yml b/.github/workflows/V8-reanimated-build-check-nightly.yml index 16e26d20d4ba..ba432035006e 100644 --- a/.github/workflows/V8-reanimated-build-check-nightly.yml +++ b/.github/workflows/V8-reanimated-build-check-nightly.yml @@ -1,6 +1,4 @@ name: V8 Reanimated build check [Nightly] -env: - YARN_ENABLE_IMMUTABLE_INSTALLS: 0 on: pull_request: paths: diff --git a/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml b/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml index f79e44396245..0114507ed7e2 100644 --- a/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml +++ b/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml @@ -1,6 +1,4 @@ name: React Native nightly Reanimated build check [Nightly] -env: - YARN_ENABLE_HARDENED_MODE: 0 on: pull_request: paths: diff --git a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml index ed2c2df02b53..3a0547ec0831 100644 --- a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml +++ b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml @@ -1,6 +1,4 @@ name: Windows hosted app Reanimated build check [Nightly] -env: - YARN_ENABLE_IMMUTABLE_INSTALLS: 0 on: pull_request: paths: From 1e3e2912bf1e95fbc58e19ba0e1464b898cbd61b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20=C5=BBelawski?= Date: Fri, 25 Oct 2024 14:13:52 +0200 Subject: [PATCH 05/13] chore: Remove env variables 2 --- .github/workflows/V8-reanimated-build-check-nightly.yml | 2 ++ .../react-native-nightly-reanimated-build-check-nightly.yml | 2 ++ .../windows-hosted-app-reanimated-build-check-nightly.yml | 2 ++ 3 files changed, 6 insertions(+) diff --git a/.github/workflows/V8-reanimated-build-check-nightly.yml b/.github/workflows/V8-reanimated-build-check-nightly.yml index ba432035006e..16e26d20d4ba 100644 --- a/.github/workflows/V8-reanimated-build-check-nightly.yml +++ b/.github/workflows/V8-reanimated-build-check-nightly.yml @@ -1,4 +1,6 @@ name: V8 Reanimated build check [Nightly] +env: + YARN_ENABLE_IMMUTABLE_INSTALLS: 0 on: pull_request: paths: diff --git a/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml b/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml index 0114507ed7e2..2491f8177cd8 100644 --- a/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml +++ b/.github/workflows/react-native-nightly-reanimated-build-check-nightly.yml @@ -1,4 +1,6 @@ name: React Native nightly Reanimated build check [Nightly] +env: + YARN_ENABLE_IMMUTABLE_INSTALLS: 0 on: pull_request: paths: diff --git a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml index 3a0547ec0831..ed2c2df02b53 100644 --- a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml +++ b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml @@ -1,4 +1,6 @@ name: Windows hosted app Reanimated build check [Nightly] +env: + YARN_ENABLE_IMMUTABLE_INSTALLS: 0 on: pull_request: paths: From 7bf1ccec0352a2b81e9b9b748e5cf00c1539ff9f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20=C5=BBelawski?= Date: Fri, 25 Oct 2024 14:41:21 +0200 Subject: [PATCH 06/13] chore: Debug --- .github/workflows/V8-reanimated-build-check-nightly.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/V8-reanimated-build-check-nightly.yml b/.github/workflows/V8-reanimated-build-check-nightly.yml index 16e26d20d4ba..8c9df9c4a764 100644 --- a/.github/workflows/V8-reanimated-build-check-nightly.yml +++ b/.github/workflows/V8-reanimated-build-check-nightly.yml @@ -38,14 +38,20 @@ jobs: - name: Install dependencies working-directory: ${{ env.APP_NAME }} run: yarn install + - name: Debug print + working-directory: ${{ env.APP_NAME }} + run: ls node_modules && ls node_modules/@react-native && ls node_modules/@react-native/gradle-plugin - name: Install Reanimated working-directory: ${{ env.APP_NAME }} run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}" - name: Install test dependencies working-directory: ${{ env.APP_NAME }} run: yarn add react-native-v8 v8-android-jit + - name: Debug print + working-directory: ${{ env.APP_NAME }} + run: ls node_modules && ls node_modules/@react-native && ls node_modules/@react-native/gradle-plugin - name: Configure V8 run: node reanimated_repo/.github/workflows/helper/configureV8.js - - name: Build Android ${{ env.APP_NAME }} + - name: Build Android working-directory: ${{ env.APP_NAME }}/android run: ./gradlew assembleDebug --console=plain From 31906dba5ce0e463531f212532b68e165a370ec7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20=C5=BBelawski?= Date: Fri, 25 Oct 2024 15:19:35 +0200 Subject: [PATCH 07/13] chore: Debug2 --- .github/workflows/V8-reanimated-build-check-nightly.yml | 5 +---- .../windows-hosted-app-reanimated-build-check-nightly.yml | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/V8-reanimated-build-check-nightly.yml b/.github/workflows/V8-reanimated-build-check-nightly.yml index 8c9df9c4a764..5ef5a5d3a366 100644 --- a/.github/workflows/V8-reanimated-build-check-nightly.yml +++ b/.github/workflows/V8-reanimated-build-check-nightly.yml @@ -34,13 +34,10 @@ jobs: run: npx react-native init ${{ env.APP_NAME }} --skip-install - name: Setup Yarn Modern working-directory: ${{ env.APP_NAME }} - run: touch yarn.lock && corepack enable && yarn set version berry + run: touch yarn.lock && corepack enable && yarn set version berry && yarn config set nodeLinker node-modules - name: Install dependencies working-directory: ${{ env.APP_NAME }} run: yarn install - - name: Debug print - working-directory: ${{ env.APP_NAME }} - run: ls node_modules && ls node_modules/@react-native && ls node_modules/@react-native/gradle-plugin - name: Install Reanimated working-directory: ${{ env.APP_NAME }} run: yarn add "react-native-reanimated@https://github.com/software-mansion/react-native-reanimated.git#workspace=react-native-reanimated&commit=${{ github.sha }}" diff --git a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml index ed2c2df02b53..25aa08782c76 100644 --- a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml +++ b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml @@ -29,7 +29,7 @@ jobs: run: npx react-native init ${{ env.APP_NAME }} --skip-install - name: Setup Yarn Modern working-directory: ${{ env.APP_NAME }} - run: touch yarn.lock && corepack enable && yarn set version berry + run: touch yarn.lock && corepack enable && yarn set version berry && yarn config set nodeLinker node-modules - name: Install dependencies working-directory: ${{ env.APP_NAME }} run: yarn From 3076f00de1c019ff59f52a5123e51c514b8ddbe2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20=C5=BBelawski?= Date: Fri, 25 Oct 2024 15:38:38 +0200 Subject: [PATCH 08/13] chore: Debug3 --- .../V8-reanimated-build-check-nightly.yml | 18 ++++++++++++------ ...sted-app-reanimated-build-check-nightly.yml | 13 ++++++++++--- 2 files changed, 22 insertions(+), 9 deletions(-) diff --git a/.github/workflows/V8-reanimated-build-check-nightly.yml b/.github/workflows/V8-reanimated-build-check-nightly.yml index 5ef5a5d3a366..b79a507fb794 100644 --- a/.github/workflows/V8-reanimated-build-check-nightly.yml +++ b/.github/workflows/V8-reanimated-build-check-nightly.yml @@ -20,6 +20,7 @@ jobs: cancel-in-progress: true env: APP_NAME: app + LATEST_SUPPORTED_RN_VERSION_IN_V8: 0.75 steps: - name: Check out uses: actions/checkout@v4 @@ -30,11 +31,19 @@ jobs: with: distribution: 'zulu' java-version: '17' - - name: Create React Native App - run: npx react-native init ${{ env.APP_NAME }} --skip-install + - name: + Setup Yarn + # Sometimes `npx react-native init` fails due to dependency mismatches or other + # rather vague errors. This is a workaround for that. + run: corepack enable && yarn init + - name: Install React Native + run: yarn add react-native + - name: Create app + run: | + yarn react-native init ${{ env.APP_NAME }} --version ${{env.LATEST_SUPPORTED_RN_VERSION_IN_V8}} --skip-install --pm yarn --skip-install --install-pods false --skip-git-init - name: Setup Yarn Modern working-directory: ${{ env.APP_NAME }} - run: touch yarn.lock && corepack enable && yarn set version berry && yarn config set nodeLinker node-modules + run: touch yarn.lock && yarn set version berry && yarn config set nodeLinker node-modules - name: Install dependencies working-directory: ${{ env.APP_NAME }} run: yarn install @@ -44,9 +53,6 @@ jobs: - name: Install test dependencies working-directory: ${{ env.APP_NAME }} run: yarn add react-native-v8 v8-android-jit - - name: Debug print - working-directory: ${{ env.APP_NAME }} - run: ls node_modules && ls node_modules/@react-native && ls node_modules/@react-native/gradle-plugin - name: Configure V8 run: node reanimated_repo/.github/workflows/helper/configureV8.js - name: Build Android diff --git a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml index 25aa08782c76..3bc75e185e92 100644 --- a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml +++ b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml @@ -25,11 +25,18 @@ jobs: with: distribution: 'zulu' java-version: '17' - - name: Create React Native App - run: npx react-native init ${{ env.APP_NAME }} --skip-install + - name: Setup Yarn + # Sometimes `npx react-native init` fails due to dependency mismatches or other + # rather vague errors. This is a workaround for that. + run: corepack enable && yarn init + - name: Install React Native + run: yarn add react-native + - name: Create app + run: | + yarn react-native init ${{ env.APP_NAME }} --pm yarn --skip-install --install-pods false --skip-git-init - name: Setup Yarn Modern working-directory: ${{ env.APP_NAME }} - run: touch yarn.lock && corepack enable && yarn set version berry && yarn config set nodeLinker node-modules + run: touch yarn.lock && yarn set version berry - name: Install dependencies working-directory: ${{ env.APP_NAME }} run: yarn From 0e126638472214a518744b6c16aa7693b5d12053 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20=C5=BBelawski?= Date: Fri, 25 Oct 2024 15:45:07 +0200 Subject: [PATCH 09/13] chore: Debug4 --- .../windows-hosted-app-reanimated-build-check-nightly.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml index 3bc75e185e92..b242d702cec8 100644 --- a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml +++ b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml @@ -28,7 +28,9 @@ jobs: - name: Setup Yarn # Sometimes `npx react-native init` fails due to dependency mismatches or other # rather vague errors. This is a workaround for that. - run: corepack enable && yarn init + run: corepack enable + - name: Init yarn repo + run: yarn init - name: Install React Native run: yarn add react-native - name: Create app From e484bfe84db8d7e6e1e579ea10d3187c462f122c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20=C5=BBelawski?= Date: Fri, 25 Oct 2024 15:58:49 +0200 Subject: [PATCH 10/13] chore: Debug5 --- .../windows-hosted-app-reanimated-build-check-nightly.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml index b242d702cec8..587c2eed22d4 100644 --- a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml +++ b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml @@ -28,9 +28,7 @@ jobs: - name: Setup Yarn # Sometimes `npx react-native init` fails due to dependency mismatches or other # rather vague errors. This is a workaround for that. - run: corepack enable - - name: Init yarn repo - run: yarn init + run: corepack enable && yarn init --yes - name: Install React Native run: yarn add react-native - name: Create app From 841ef3511624d8f1950ce5a1263c3e1d0c5b8c25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20=C5=BBelawski?= Date: Fri, 25 Oct 2024 16:06:25 +0200 Subject: [PATCH 11/13] chore: Debug6 --- .../windows-hosted-app-reanimated-build-check-nightly.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml index 587c2eed22d4..d97e4afe8913 100644 --- a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml +++ b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml @@ -32,8 +32,7 @@ jobs: - name: Install React Native run: yarn add react-native - name: Create app - run: | - yarn react-native init ${{ env.APP_NAME }} --pm yarn --skip-install --install-pods false --skip-git-init + run: yarn react-native init ${{ env.APP_NAME }} --pm yarn --skip-install - name: Setup Yarn Modern working-directory: ${{ env.APP_NAME }} run: touch yarn.lock && yarn set version berry From 79232d8355040dce5e251ed8a2100747ce292da0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20=C5=BBelawski?= Date: Fri, 25 Oct 2024 16:11:36 +0200 Subject: [PATCH 12/13] chore: Debug7 --- .../windows-hosted-app-reanimated-build-check-nightly.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml index d97e4afe8913..0a18d680f283 100644 --- a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml +++ b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml @@ -30,9 +30,9 @@ jobs: # rather vague errors. This is a workaround for that. run: corepack enable && yarn init --yes - name: Install React Native - run: yarn add react-native + run: yarn add @react-native-community/cli - name: Create app - run: yarn react-native init ${{ env.APP_NAME }} --pm yarn --skip-install + run: yarn @react-native-community/cli init ${{ env.APP_NAME }} --pm yarn --skip-install --install-pods false --skip-git-init - name: Setup Yarn Modern working-directory: ${{ env.APP_NAME }} run: touch yarn.lock && yarn set version berry From 258a56d96698826c4ab63ea7552fe20d345570b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tomasz=20=C5=BBelawski?= Date: Fri, 25 Oct 2024 16:16:21 +0200 Subject: [PATCH 13/13] chore: Debug8 --- .../windows-hosted-app-reanimated-build-check-nightly.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml index 0a18d680f283..dc188fe19b48 100644 --- a/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml +++ b/.github/workflows/windows-hosted-app-reanimated-build-check-nightly.yml @@ -32,7 +32,7 @@ jobs: - name: Install React Native run: yarn add @react-native-community/cli - name: Create app - run: yarn @react-native-community/cli init ${{ env.APP_NAME }} --pm yarn --skip-install --install-pods false --skip-git-init + run: yarn rnc-cli init ${{ env.APP_NAME }} --pm yarn --skip-install --install-pods false --skip-git-init - name: Setup Yarn Modern working-directory: ${{ env.APP_NAME }} run: touch yarn.lock && yarn set version berry