From 04fa0aa4f6bec199450a415ba15de111bafaf1d6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20=C5=81opaci=C5=84ski?= Date: Fri, 25 Oct 2024 11:06:25 +0200 Subject: [PATCH 1/5] Remove effect from useDerivedValue which invalidated shared value during hot reload --- .../react-native-reanimated/src/hook/useDerivedValue.ts | 6 ------ 1 file changed, 6 deletions(-) diff --git a/packages/react-native-reanimated/src/hook/useDerivedValue.ts b/packages/react-native-reanimated/src/hook/useDerivedValue.ts index 541c1c915dfc..a43ef41ee1bb 100644 --- a/packages/react-native-reanimated/src/hook/useDerivedValue.ts +++ b/packages/react-native-reanimated/src/hook/useDerivedValue.ts @@ -73,11 +73,5 @@ export function useDerivedValue( }; }, dependencies); - useEffect(() => { - return () => { - initRef.current = null; - }; - }, []); - return sharedValue; } From 17c8a1891df84421a8cd42003f9493d3c0806c6a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20=C5=81opaci=C5=84ski?= Date: Fri, 25 Oct 2024 11:13:12 +0200 Subject: [PATCH 2/5] Disable logger strict mode by default --- packages/react-native-reanimated/src/logger/logger.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/react-native-reanimated/src/logger/logger.ts b/packages/react-native-reanimated/src/logger/logger.ts index 99f8d98cc5b3..ddf68cedcc3d 100644 --- a/packages/react-native-reanimated/src/logger/logger.ts +++ b/packages/react-native-reanimated/src/logger/logger.ts @@ -39,7 +39,7 @@ function logToConsole(data: LogData) { export const DEFAULT_LOGGER_CONFIG: LoggerConfigInternal = { logFunction: logToConsole, level: LogLevel.warn, - strict: true, + strict: false, }; function formatMessage(message: string) { @@ -110,8 +110,8 @@ export function updateLoggerConfig(options?: Partial) { registerLoggerConfig({ ...__reanimatedLoggerConfig, // Don't reuse previous level and strict values from the global config - level: options?.level ?? LogLevel.warn, - strict: options?.strict ?? false, + level: options?.level ?? DEFAULT_LOGGER_CONFIG.level, + strict: options?.strict ?? DEFAULT_LOGGER_CONFIG.strict, }); } From 2705519c85217bf7df4eefad7e51878390a53f6b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20=C5=81opaci=C5=84ski?= Date: Fri, 25 Oct 2024 11:14:09 +0200 Subject: [PATCH 3/5] Adjust docs to match new default config --- .../docs-reanimated/docs/debugging/logger-configuration.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/docs-reanimated/docs/debugging/logger-configuration.mdx b/packages/docs-reanimated/docs/debugging/logger-configuration.mdx index d20ce87b6057..60a980f9d547 100644 --- a/packages/docs-reanimated/docs/debugging/logger-configuration.mdx +++ b/packages/docs-reanimated/docs/debugging/logger-configuration.mdx @@ -23,7 +23,7 @@ import { // This is the default configuration configureReanimatedLogger({ level: ReanimatedLogLevel.warn, - strict: true, // Reanimated runs in strict mode by default + strict: false, // Change this to `true` to see more useful warnings }); ``` From e7630d1d7197a66063b912a4c6cbc7d73f58510b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20=C5=81opaci=C5=84ski?= Date: Fri, 25 Oct 2024 12:03:40 +0200 Subject: [PATCH 4/5] Revert docs changes --- .../docs-reanimated/docs/debugging/logger-configuration.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/docs-reanimated/docs/debugging/logger-configuration.mdx b/packages/docs-reanimated/docs/debugging/logger-configuration.mdx index 60a980f9d547..d20ce87b6057 100644 --- a/packages/docs-reanimated/docs/debugging/logger-configuration.mdx +++ b/packages/docs-reanimated/docs/debugging/logger-configuration.mdx @@ -23,7 +23,7 @@ import { // This is the default configuration configureReanimatedLogger({ level: ReanimatedLogLevel.warn, - strict: false, // Change this to `true` to see more useful warnings + strict: true, // Reanimated runs in strict mode by default }); ``` From ecc0709927d368738ec23b92475cf5c0ebb9dd4d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20=C5=81opaci=C5=84ski?= Date: Tue, 29 Oct 2024 15:22:19 +0100 Subject: [PATCH 5/5] Re-enable logger strict mode in the config by default --- packages/react-native-reanimated/src/logger/logger.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native-reanimated/src/logger/logger.ts b/packages/react-native-reanimated/src/logger/logger.ts index ddf68cedcc3d..da21230734e2 100644 --- a/packages/react-native-reanimated/src/logger/logger.ts +++ b/packages/react-native-reanimated/src/logger/logger.ts @@ -39,7 +39,7 @@ function logToConsole(data: LogData) { export const DEFAULT_LOGGER_CONFIG: LoggerConfigInternal = { logFunction: logToConsole, level: LogLevel.warn, - strict: false, + strict: true, }; function formatMessage(message: string) {