Fix elements dissapearing due to high values set to threshold props in ReanimatedSwipeable
#3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bert
approved these changes
Oct 14, 2024
latekvo
deleted the
@latekvo/fix-swipeable-elements-sometimes-dissapearing-when-treshold-set-high
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove mechanism hiding elements which are already out of screen to fix a bug where this mechanism sometimes fired when the element was still on the screen.
Still researching why elements had to be hidden in the first place.
First commit adding the feature which is removed in this PR: (link)
Test plan
Swipeable ReanimationexampleReanimatedswipeableredelementthresholdset to80, which is2times the width of the element, the swipeable fails to closeredelement wouldn't be visible