Fix swipeable swiping to left when no renderRightActions is set
#3145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment is not present (cherry picked from commit 2f511a3)
latekvo
changed the title
renderRightActions is set
m-bert
reviewed
Oct 10, 2024
m-bert
approved these changes
Oct 10, 2024
| if (rowState.value === 1) { | ||
| return leftWidth.value; | ||
| } else if (rowState.value === -1) { | ||
| return -rowWidth.value - rightOffset.value; | ||
| return -rowWidth.value - rightOffset.value!; |
There was a problem hiding this comment.
I'd think about changing it to use ternary operator:
return rowState.value === 1
? leftWidth.value
: rowState.value === -1
? -rowWidth.value - rightOffset.value!
: 0;But it has 3 options, so it may look a bit messy. It's up to you to decide 😅
There was a problem hiding this comment.
It looks ok, done in 5e8ded8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed
Swipeablebeing able to be opened to the left when no right element is present.This was caused by incorrectly set
rightOffset, equal to0when no elements were present, even though it should've been set torowWidthTest plan
renderRightActionspropSwipeablecould've still been opened to the left, and now it can't be.