Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failing test for #3555 + the fix itself #3604

Closed
wants to merge 3 commits into from
Closed

Add failing test for #3555 + the fix itself #3604

wants to merge 3 commits into from

Commits on May 24, 2020

  1. Add failing test for socketio#3555

    @dasilvacontin
    dasilvacontin committed May 24, 2020
    Configuration menu
    Copy the full SHA
    5492655 View commit details
    Browse the repository at this point in the history

  2. Make sure correct client files are served, fixes socketio#3555 

    The old logic missed some places and was not able to look into the node_modules of the socket.io library itself.

The new logic always uses require.resolve to lookup the "correct" location for the socker.io-client library and then construct the path correctly

This fixes socketio#3555 

A fast release of a fixed version would be awesome!
    @Apollon77 @dasilvacontin
    Apollon77 authored and dasilvacontin committed May 24, 2020
    Configuration menu
    Copy the full SHA
    a04e42c View commit details
    Browse the repository at this point in the history

  3. Update lib/index.js 

    Co-authored-by: David da Silva <[email protected]>
    @Apollon77 @dasilvacontin
    Apollon77 and dasilvacontin committed May 24, 2020
    Configuration menu
    Copy the full SHA
    804827c View commit details
    Browse the repository at this point in the history