Add failing test for #3555 + the fix itself #3604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dasilvacontin
force-pushed
the
add-failing-test-plus-fix-for-3555
branch
from
a05b686
to
5492655
Compare
The old logic missed some places and was not able to look into the node_modules of the socket.io library itself. The new logic always uses require.resolve to lookup the "correct" location for the socker.io-client library and then construct the path correctly This fixes socketio#3555 A fast release of a fixed version would be awesome!
Co-authored-by: David da Silva <[email protected]>
5 tasks
dasilvacontin
changed the title
|
Superseded by 7603da7 (included in |
This was referenced Oct 30, 2022
This was referenced Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kind of change this PR does introduce
Current behaviour
Socket.io server ignores 'socket.io-client' module installed inside
socket.iowhen there's an installation of 'socket.io-client' sibling to 'socket.io'.New behaviour
Now uses closest 'socket.io-client' installation.
Other information (e.g. related issues)
Fix is by @Apollon77, taken from PR #3557. Their fix fixes #3555.
I added a failing test to show it actually had a behavior issue prior to the fix, and give an example of how it fails. Plus to prevent a regression in the future.