update type returned from emit #3843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a `true` here breaks using union types to do emits.. ie this no longer works
`(channel ? io.to(channel) : io).emit("stuff", message);`
|
maybe someone can run with this - i don't know why the unit tests are failing but you shouldn't use true as a type |
darrachequesne
pushed a commit
that referenced
this pull request
Mar 18, 2021
```
(channel ? io.to(channel) : io).emit("stuff", message);
```
would no longer compile.
Related: #3844
|
Merged as 1a72ae4. Thanks a lot! 👍 |
dzad
pushed a commit
to dzad/socket.io
that referenced
this pull request
May 29, 2023
```
(channel ? io.to(channel) : io).emit("stuff", message);
```
would no longer compile.
Related: socketio#3844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a
truehere breaks using union types to do emits.. ie this no longer works(channel ? io.to(channel) : io).emit("stuff", message);The kind of change this PR does introduce
Current behavior
New behavior
Other information (e.g. related issues)