-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exports the Namespace and Socket type v3 #3699
Conversation
Exports the Namespace and Socket type from MJS wrapper
May I ask what the use case is? For TypeScript, I understand that it can be used for englobing types: import { Namespace } from "socket.io";
class Application {
private mainNamespace: Namespace;
} But is this needed for ES modules? |
@darrachequesne |
@ptejada oh ok. Could you please open an issue in Jetbrains issue tracker then? (here I guess: https://youtrack.jetbrains.com/issues/WEB) |
I don't think is an issue of the IDE. What is the purpose of the That is the file the IDE is referencing which only exports I don't have enough information to log bug report for the IDE. All I know is making the edits in the PR fixes the references. |
Exports the Namespace and Socket type from MJS wrapper
The kind of change this PR does introduce
Current behavior
MJS wrapper only exports Server
New behavior
MJS wrapper exports Server, Namaspace and Socket types
Other information (e.g. related issues)
I would say is a continuation of PR #3684 and my comment there
#3684 (comment)