Allow usage of a custom replacer and reviver #112
Merged
+22
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmocanu
force-pushed
the
custom-reviver-replacer
branch
from
822816b
to
ebf2bc4
Compare
|
Updated to fix missing line that made prettier unhappy. I hadn't run the CI locally since I can't |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a need for a custom replacer and reviver, but because
tryParseis outside of the class, a reviver cannot be inserted. We'd have to copy/paste duplicate the entire parser to make this small modification on our end instead of just inheriting from it. Hence this PR, to allow for this functionality for everyone.