fix(binary): fix binary events being marked as regular events (#76)

So that the emitter can send binary payloads to a Socket.IO server (only applies to `[email protected]`). Related: - socketio/socket.io-parser@dc4f475 - socketio/socket.io@f48a06c Co-authored-by: Victor Soto <[email protected]>
socketio · Dec 29, 2020 · 52483f9 · 52483f9
1 parent 4ad26ee
commit 52483f9
Show file tree

Hide file tree

Showing 3 changed files with 228 additions and 179 deletions.
diff --git a/index.js b/index.js
@@ -6,6 +6,7 @@
 var client = require('redis').createClient;
 var parser = require('socket.io-parser');
 var msgpack = require('notepack.io');
+var hasBin = require('has-binary2');
 var debug = require('debug')('socket.io-emitter');
 
 /**
@@ -123,7 +124,7 @@ Emitter.prototype.of = function(nsp){
 Emitter.prototype.emit = function(){
   // packet
   var args = Array.prototype.slice.call(arguments);
-  var packet = { type: parser.EVENT, data: args, nsp: this.nsp };
+  var packet = { type: hasBin(args) ? parser.BINARY_EVENT : parser.EVENT, data: args, nsp: this.nsp };
 
   var opts = {
     rooms: this._rooms,