Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typings): export extraHeaders option #1410

Merged
merged 2 commits into from
Nov 20, 2020

Conversation

justLuiz
Copy link
Contributor

@justLuiz justLuiz commented Nov 19, 2020

related: #1405

Note: the socket.io.js file is the generated output of make socket.io.js, and should not be manually modified.

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

extraHeaders is not exported in type definition.

New behavior

extraHeaders is now exported in type definition.

Other information (e.g. related issues)

@justLuiz
Copy link
Contributor Author

this type, it should be part of the engine.io-client package but it is not a typescript yet, you may need to move these types later, taking care not to break current consumers

@darrachequesne darrachequesne merged commit b3de861 into socketio:master Nov 20, 2020
@darrachequesne
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants