Skip to content

Conversation

valodzka
Copy link
Contributor

This PR does 2 things:

  1. Give heartbeat thread clear name so it's easy to spot it in thread dumps.
  2. Set heartbeat thread daemon flag so it won't stop the app from exiting when the scheduler wasn't stopped correctly.

@darrachequesne darrachequesne merged commit 7c9c382 into socketio:master Jan 22, 2021
@darrachequesne
Copy link
Member

@valodzka awesome, thanks!

@Clair-yoon
Copy link

Clair-yoon commented Jan 23, 2025

@valodzka Hello, would it be possible to apply this change to version 1.0.2 as well?
I'm struggling with delayed heartbeats when the EventThread is busy.
Your help on this matter would be much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants