Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update CI Window Machine #289

Merged
merged 2 commits into from
Sep 12, 2024
Merged

feat: Update CI Window Machine #289

merged 2 commits into from
Sep 12, 2024

Conversation

DOlufemi
Copy link
Contributor

@DOlufemi DOlufemi commented Sep 12, 2024

  • Tests written and linted
  • Documentation written
  • Commit history is tidy

What this does

  • Upgrade Circle CI window machine version
  • Ensure appropriate JDK version is used when running tests
  • Upgrade test

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2024

CLA assistant check
All committers have signed the CLA.

@DOlufemi DOlufemi force-pushed the feat/ci-windows-machine branch 2 times, most recently from a0cfdb2 to fa67e66 Compare September 12, 2024 11:33
@DOlufemi DOlufemi changed the title Feat/ci windows machine feat: Update CI Window Machine Sep 12, 2024
@DOlufemi DOlufemi marked this pull request as ready for review September 12, 2024 11:54
@DOlufemi DOlufemi requested a review from a team as a code owner September 12, 2024 11:54
@@ -415,7 +415,7 @@ function getVersionBuildInfo(
}
}

async function getGradleVersion(
export async function getGradleVersion(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is now being used to set up the test environment.

@DOlufemi DOlufemi merged commit 628c688 into main Sep 12, 2024
4 checks passed
@DOlufemi DOlufemi deleted the feat/ci-windows-machine branch September 12, 2024 13:36
@snyksec
Copy link

snyksec commented Sep 12, 2024

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants