feat: [OSM-892] added support for gradle 8 #280
Conversation
There was a problem hiding this comment.
I might be missing something but are you replacing existing tests for Gradle 7 with new tests for Gradle 8? If so, shouldn't we support both?
There was a problem hiding this comment.
No, before this PR, tests were running only on Gradle 4, 5 and 6 with Java version 8. What I've did was to modify the tests so they could also run with Java 17 (needed for Gradle 7 and Gradle 8)
There was a problem hiding this comment.
Ok, but it still works for 4,5,6 on Java 8 with these changes? 🤷🏻
| '-Dorg.gradle.console=plain', | ||
| '-PonlySubProject=.', | ||
| '-I', | ||
| it.each(NO_CONFIGURATION_CACHE_VERSIONS)( |
There was a problem hiding this comment.
nit, but I think the constant is making it harder to read what this test does if the variable is not re-used anywhere.
37IulianPopovici
force-pushed
the
feat/add-support-for-gradle-8
branch
from
d8554cb
to
50041fe
Compare
37IulianPopovici
force-pushed
the
feat/add-support-for-gradle-8
branch
from
50041fe
to
8650306
Compare
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What this does
Adds support for Gradle 8
Enhanced tests to also run on Gradle 7 and Gradle 8
Additional questions