-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide better safety for configuration #128
Comments
How about a way to observe whether the filters do anything? So if you |
I guess the case I'm worried about here is a filter configured to |
I mean at some level the user has to be responsible for configuration input right? You also cannot control what a user calls the event (they could make one called Could you maybe add logging periodically of what the filter inputs did so a user can more easily figure out that they messed up? |
Yeah that's fair - could be over-egging. For custom scripting transformations I think providing tests would be nice anyway. But yes for this, perhaps periodic logs are indeed good enough |
Some of our transformations seem easy to misconfigure, in ways that we can't really validate for. Eg. if you provide a typo in an event_name, the enriched filters will simply treat all those events as not matched.
We also can't log the values due to user data privacy concerns in the intended deployment model...
It would be great to think of some creative solutions for this. One thing that I think could work well (and would be v useful to scripting transformations) is to provide a harness to test your config against certain values locally/without processing all the way through. Like a 'transformation config test harness'... But I'm not tied to that solution, I'd love to hear ideas on the topic.
(relevant discussion: #125 (comment))
The text was updated successfully, but these errors were encountered: