Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better safety for configuration #128

Open
colmsnowplow opened this issue Jun 1, 2022 · 4 comments
Open

Provide better safety for configuration #128

colmsnowplow opened this issue Jun 1, 2022 · 4 comments

Comments

@colmsnowplow
Copy link
Collaborator

colmsnowplow commented Jun 1, 2022

Some of our transformations seem easy to misconfigure, in ways that we can't really validate for. Eg. if you provide a typo in an event_name, the enriched filters will simply treat all those events as not matched.

We also can't log the values due to user data privacy concerns in the intended deployment model...

It would be great to think of some creative solutions for this. One thing that I think could work well (and would be v useful to scripting transformations) is to provide a harness to test your config against certain values locally/without processing all the way through. Like a 'transformation config test harness'... But I'm not tied to that solution, I'd love to hear ideas on the topic.

(relevant discussion: #125 (comment))

@jbeemster
Copy link
Member

How about a way to observe whether the filters do anything? So if you event_name = x but after a configured time the filter is never activated to log a warning?

@colmsnowplow
Copy link
Collaborator Author

I guess the case I'm worried about here is a filter configured to event_name = pagee_view -> The filter will be active, but the typo will cause it to filter out all legitimate page views, but this will be invisible until someone notices the problem later.

@jbeemster
Copy link
Member

I mean at some level the user has to be responsible for configuration input right? You also cannot control what a user calls the event (they could make one called pagee_view that actually works).

Could you maybe add logging periodically of what the filter inputs did so a user can more easily figure out that they messed up?

@colmsnowplow
Copy link
Collaborator Author

Yeah that's fair - could be over-egging. For custom scripting transformations I think providing tests would be nice anyway. But yes for this, perhaps periodic logs are indeed good enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants