Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg not being picked up from current working directory #146

Open
majinzero opened this issue May 27, 2020 · 13 comments
Open

ffmpeg not being picked up from current working directory #146

majinzero opened this issue May 27, 2020 · 13 comments
Assignees
Labels
bug Something isn't working macOS only present on macOS

Comments

@majinzero
Copy link

hello, I have the error that he cannot find the ffmpeg file on macos. I have already copied them to every conceivable place, unfortunately none. Unfortunately, the same error message always appears.

I use Macos 10.15.4 latest ffmpeg version.

FFmpeg is missing!
Destreamer requires a fairly recent release of FFmpeg to download videos

@snobu
Copy link
Owner

snobu commented May 27, 2020

Copy to destreamer/ directory and make sure it's executable (chmod +x ffmpeg)

@majinzero
Copy link
Author

Untitled

@snobu
Copy link
Owner

snobu commented May 27, 2020

Hmm, that should have worked, i need to take a look at our code and check why it doesn't pick up ffmpeg binaries from project root. Meanwhile try to symlink to /usr/local/bin/ffmpeg or any other location that is in your $PATH. If you type ffmpeg at your command prompt you should get the ffmpeg usage screen. If that happens then destreamer should run fine.

image

@majinzero
Copy link
Author

it works with the simlink
thx

@snobu
Copy link
Owner

snobu commented May 27, 2020

Amended title to reflect the underlying problem.
New problem definition: we're not trying to run ffmpeg from current working folder.
We should try current folder then fall back to $PATH.

@snobu snobu changed the title FFMPEG Macos failure ffmpeg not being picked up from current working directory May 27, 2020
@snobu snobu added the bug Something isn't working label May 27, 2020
@lukaarma
Copy link
Collaborator

lukaarma commented Jun 18, 2020

This issue is not present on Windows 10 (and I will take a guess and say also the previous Windows, since execSync uses cmd)
Can't help anymore, I don't have acces to a macOS system

@lukaarma lukaarma added the macOS only present on macOS label Jun 18, 2020
@Mennaruuk
Copy link

One workaround I found is to copy the file into one of the folders in $PATH.
For example, sudo cp path_of_ffmpeg_file /usr/local/bin.
I tried adding the ffmpeg folder into $PATH, but it kept failing for me.

@snobu
Copy link
Owner

snobu commented Jul 16, 2020

brew install ffmpeg

It's faster but of course you need brew installed.

@snobu snobu self-assigned this Aug 22, 2020
@lukaarma lukaarma mentioned this issue Sep 23, 2020
@lukaarma
Copy link
Collaborator

This bug it's replicable on windows using git-bash

@lukaarma
Copy link
Collaborator

On *nix we could try to search the local folder for the exe and set a flag if so
Or do the same both time we need to execute ffmpeg/aria2c

@daarong
Copy link

daarong commented Dec 17, 2020

I am experiencing this, Win10. I'm not the greatest with npm so I did not get this resolved.

I simply dropped ffmpeg binary into the folder - - this application worked wonders after that.

@amnotabot
Copy link

Hi @lukaarma , New Here Thanks for the help,

I get different error , tried all suggested actions above, still get the same error, regardless of how I install ffmpeg and of the terminal I use

[FATAL ERROR] The FFmpeg version currently installed is too old!
Destreamer requires a fairly recent release of FFmpeg to download videos

image

Any ideas please?

@snobu
Copy link
Owner

snobu commented Dec 28, 2022

Put ffmpeg.exe in your PATH, Run -> sysdm.cpl -> Advanced System Settings -> Advanced.

You can check by typing ffmpeg in your terminal from any directory.

Also don't use that MINGW64 terminal host as it's going to bring you trouble. Use cmd.exe or Windows Terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working macOS only present on macOS
Projects
None yet
Development

No branches or pull requests

6 participants