Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meson build scripts to align with CMake scripts #116

Open
cschreib opened this issue Sep 1, 2023 · 3 comments
Open

Update meson build scripts to align with CMake scripts #116

cschreib opened this issue Sep 1, 2023 · 3 comments
Labels
enhancement New feature or request help wanted Seeking external contributor
Milestone

Comments

@cschreib
Copy link
Member

cschreib commented Sep 1, 2023

As of #115, the CMake scripts were updated to provide better support for building snitch as a shared library. The meson scripts were updated in the process, but only minimally since I don't know enough of meson... Here is what is still missing:

  • If compiling the library with GCC or clang, we should set -fvisibility=hidden -fvisibility-inlines-hidden (only when building the library, not when consuming it). Done in Set -fvisibility=hidden and -fvisibility-inlines-hidden for Meson #138.
  • This one I'm less sure; maybe it's not "the meson way". I think the script should only build one of [shared, static, header-only]. Currently the scripts can build any combination of these, which is probably OK if building [static, header-only], but [shared, static] or [shared, header-only] is likely not to work as expected since snitch_config.hpp needs to be different in both cases. If the snitch_config.hpp can be re-generated for each target, then that's fine, but it seems to me it would just complicate the build script.
@cschreib cschreib added enhancement New feature or request help wanted Seeking external contributor labels Sep 1, 2023
@cschreib cschreib added this to the v1.x milestone Sep 1, 2023
@cschreib
Copy link
Member Author

cschreib commented Sep 1, 2023

@willwray Since you contributed the original meson scripts, I was wondering if you were interested in updating this. It might not be hard, but I haven't yet climbed the learning curve on that one :)

@willwray
Copy link
Contributor

willwray commented Sep 1, 2023

I'll take a look at the weekend, and use my 'ask a friend' on the meson matrix channel if needed.

@cschreib
Copy link
Member Author

cschreib commented Nov 7, 2023

Thank you @topazus for contributing the changes to implement the first item in the list. This leaves us with the second item (whether to limit the scripts to build one type of target at a time, or support building all possible types of target at once). Any opinions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Seeking external contributor
Projects
None yet
Development

No branches or pull requests

2 participants