Skip to content

Fixed misalignment of consumables with smaller media #15493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

Godmartinz
Copy link
Member

Description

this applies the changes of #15352 to consumables' views as well.
image

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • PHP version:
  • MySQL version
  • Webserver version
  • OS version

Checklist:

Copy link

what-the-diff bot commented Sep 11, 2024

PR Summary

  • Addition of New Information Section in View
    The view file (view.blade.php) for consumables now features a new section. This has been achieved by introducing a new <div> element, labelled as "info-stack-container".

  • Enhanced UI Elements with Info-Stack Class
    Two existing sections of the view, previously organized under the classes "col-md-3 col-xs-12 col-sm-push-9" and "col-md-9 col-xs-12 col-sm-pull-3", are now also under the "info-stack" class. This implies a shared set of style and behavioral properties for improved consistency across these elements.

  • Ensuring Proper Closure of New Section
    A closing </div> tag has been added to correctly end the new "info-stack-container" section, ensuring the architecture of the web page remains intact and logical.

This PR helps in improving the overall user interface and the browsing experience for the 'consumables' section of the application.

@snipe snipe merged commit 62747a0 into grokability:develop Sep 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants