Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that there is a depreciation date before formatting #14949

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jun 24, 2024

This just checks that the depreciation_date() is not null before trying to format it

Copy link

what-the-diff bot commented Jun 24, 2024

PR Summary

  • Modification in 'ReportsController.php' File
    The code responsible for managing reports was updated. Previously, it was assuming that all assets should have a depreciation date, which may not always be the case. The new change ensures the code now checks if an asset actually has a depreciation date before trying to format it. This enhancement increases the robustness and reliable performance of our asset reporting feature by preventing potential errors.

@snipe snipe merged commit 3d32fe6 into develop Jun 24, 2024
8 of 9 checks passed
@snipe snipe deleted the fixes/depreciation_format branch June 24, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant