Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhook not being sent v7.1.15 (Checkin/Checkout) #15946

Open
2 tasks done
aHVzY2g opened this issue Dec 10, 2024 · 8 comments
Open
2 tasks done

Webhook not being sent v7.1.15 (Checkin/Checkout) #15946

aHVzY2g opened this issue Dec 10, 2024 · 8 comments
Assignees

Comments

@aHVzY2g
Copy link

aHVzY2g commented Dec 10, 2024

Debug mode

Describe the bug

Upgrading the Docker image from v7.0.12 → v7.1.15 resulted in the webhooks not working anymore for at least Checkin and Checkout. The test webhook does work. There is at least one other report of a User in Discord.

Reproduction steps

  1. Upgrade/install version 7.1.15
  2. Configure the webhook to any http-request-bin
  3. Send Test-Webhook → works, webhook send
  4. Checkout Asset → doesn't work, webhook not send
    ...

Expected behavior

The Webhook being sent, as indicated by the blue banner.

Screenshots

No response

Snipe-IT Version

v7.1.15

Operating System

snipe/snipe-it:v7.1.15 on Ubuntu host

Web Server

apache2

PHP Version

8.1.2-1ubuntu2.19

Operating System

No response

Browser

No response

Version

No response

Device

No response

Operating System

No response

Browser

No response

Version

No response

Error messages

I couldn't find any error message in debug mode, in either the "PHP-console", browser-console or docker log.

Additional context

It's a docker install using the official image snipe/snipe-it. I upgraded from v7.0.12. Mails are still being sent.

@sgross-emlix
Copy link

It's the same for us with v7.0.13 - build 15666 (master)

@Godmartinz
Copy link
Collaborator

@aHVzY2g I'm afraid I can't reproduce the issue with the information given. I just tested the three web hooks we support for check in and check outs and I received posts from all of them. Could you help me narrow down this issue, lets start with which web hook you are using?

@sgross-emlix if you would please upgrade your instance and confirm that is still the case, that would be appreciated. A lot of changes have occurred recently with web hooks & mail notifications.

@aHVzY2g
Copy link
Author

aHVzY2g commented Dec 13, 2024

@Godmartinz I just did a complete fresh install on a new system in a diffrent network.

  1. I used the provided docker-compose.yaml and ./docker/docker.env files.
  2. Set the app-version to v7.0.12, and set the local URL
  3. For testing purposes, http://requestbin.cn I used as the webhook URL, my true true target system is https://www.windmill.dev/.
  4. After completing the setup, I configure the webhook to point to http://requestbin.cn.
  5. create a test category and an asset
  6. checkout the asset to the user.
  7. The request was successfully logged in http://requestbin.cn as expected.
  8. upgrade the app-version to v7.1.15, and the redeploy using Docker Compose.
  9. After redeployment, issue the asset to the user again.
  10. This time, no request was logged in http://requestbin.cn.
Turn scripts into auto-generated UIs, APIs and cron jobs. Compose them as workflows or data pipelines. Build complex, data-intensive apps with ease. Write and deploy software 10x faster, and run it with the highest reliability and observability on the fastest self-hostable job orchestrator

EDIT: and to answer your question, I use the general webhook pointing to a windmill.dev instance. In my workflow, I use/need the checkin/checkout notifications.

@sgross-emlix
Copy link

@sgross-emlix if you would please upgrade your instance and confirm that is still the case, that would be appreciated. A lot of changes have occurred recently with web hooks & mail notifications.

I can confirm this is still an issue with the release v7.1.15 - build 16052 (master) + my patches for setting the http content-type. I used the general webhook

Sadly I'm no admin and can only inspect the client side of our instance.

During the holidays however I plan to investigate further if this issue remains.

@Godmartinz
Copy link
Collaborator

The General webhook was broken, I put in a fix for that a couple weeks ago: #15909.
I believe its on master but not in the latest version yet.

@sgross-emlix
Copy link

sgross-emlix commented Dec 17, 2024

Thanks. But for our gitlab problem the HTTP code 415 is still an issue since the Content-Type header is still missing (this is already the case for testing the hook)

#15953 was only fixed half.

We use the google webhook for now

@Godmartinz
Copy link
Collaborator

The content type was corrected in this commit: f5a9e4b

@sgross-emlix
Copy link

The content type was corrected in this commit: f5a9e4b

That's not what I meant.
This is the corrected Content-Type commit for MS and google Webhook, where it was mispelled and therefore not working.

What I meant is the missing Content-Type header for the general test webhook that leads to 415. So the general webhook can't even be tested against certain servers and therefore not be saved and therefore not be sent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants